contracts: Improve contract address derivation by athei · Pull Request #12883 · paritytech/substrate

athei · 2022-12-09T07:42:30Z

Add a prefix in order to prevent collisions with other modules
Include the constructor arguments in the derivation as they change the behavior of a contract
Remove now obsolete trait bounds (we create the id using Decode now)
Changed instantiate benchmark to check for the influence of input bytes len on runtime (they are hashed now)

The bulk of the changes are within tests where we move away from calling Pallet::contract_address where possible and use Pallet::bare_instantiate instead which returns the new contracts address.

athei · 2022-12-09T08:04:10Z

/cmd queue -c bench-bot $ pallet dev pallet_contracts

command-bot · 2022-12-09T08:04:15Z

@athei https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2139549 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 43-e5eca75f-14cb-4ea4-9aa5-788c45b3aa41 to cancel this command or /cmd cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2022-12-09T09:52:43Z

@athei Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2139549 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2139549/artifacts/download.

athei · 2022-12-09T13:07:13Z

/cmd queue -c bench-bot $ pallet dev pallet_contracts

command-bot · 2022-12-09T13:07:19Z

@athei https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2141057 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 44-094e970b-fb71-4a9b-b91b-7f5aa94a7d47 to cancel this command or /cmd cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2022-12-09T15:09:14Z

@athei Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2141057 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2141057/artifacts/download.

frame/contracts/src/lib.rs

frame/contracts/src/tests.rs

frame/contracts/src/benchmarking/mod.rs

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

athei · 2022-12-22T14:47:57Z

bot merge

paritytech-processbot · 2022-12-22T14:48:04Z

Waiting for commit status.

* Add prefix to address derivation * Extend benchmark * Fix node test * ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts * Adapt to new benchmark * Update dispatchable benchmarks * ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts * Use benchmark results * Apply suggestions from code review Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> * Don't use T::AdressGenerator directly * Rename constructor_args to input_data Co-authored-by: command-bot <> Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

athei added 2 commits December 8, 2022 20:06

Add prefix to address derivation

e9c8ffe

Extend benchmark

cce2ed9

athei added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Dec 9, 2022

Fix node test

6aaa27d

command-bot added 2 commits December 9, 2022 08:04

Merge branch 'master' of https://github.com/paritytech/substrate into…

2e8b5db

… HEAD

".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

b5f9746

athei added 2 commits December 9, 2022 12:04

Adapt to new benchmark

d271433

Update dispatchable benchmarks

d72b269

command-bot added 2 commits December 9, 2022 13:07

Merge branch 'master' of https://github.com/paritytech/substrate into…

1586a92

… HEAD

".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

0ff3bac

Use benchmark results

02c53ea

athei requested review from agryaznov and xermicus December 9, 2022 18:38

xermicus reviewed Dec 12, 2022

View reviewed changes

frame/contracts/src/lib.rs Outdated Show resolved Hide resolved

jakoblell added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Dec 12, 2022

agryaznov approved these changes Dec 13, 2022

View reviewed changes

frame/contracts/src/tests.rs Outdated Show resolved Hide resolved

frame/contracts/src/benchmarking/mod.rs Outdated Show resolved Hide resolved

xermicus approved these changes Dec 16, 2022

View reviewed changes

athei and others added 3 commits December 22, 2022 15:20

Apply suggestions from code review

9362558

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

Merge remote-tracking branch 'origin/master' into at/contract-addr

9b15567

Don't use T::AdressGenerator directly

0fa998b

Rename constructor_args to input_data

ea43cee

paritytech-processbot bot merged commit 96e71b5 into master Dec 22, 2022

paritytech-processbot bot deleted the at/contract-addr branch December 22, 2022 14:52

jasl mentioned this pull request Jan 19, 2023

Upgrade to Polkadot v0.9.37 Phala-Network/phala-blockchain#1129

Merged

librelois mentioned this pull request Jan 23, 2023

Update substrate/polkadot/cumulus from v0.9.32 to v0.9.37 moonbeam-foundation/moonbeam#2059

Closed

aurexav mentioned this pull request Feb 8, 2023

To polkadot-v0.9.37 darwinia-network/darwinia-2.0#267

Closed

kacperzuk-neti mentioned this pull request Feb 14, 2023

Polkadot v0.9.37 (pallet-nfts) liberland/liberland_substrate#244

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

contracts: Improve contract address derivation#12883

contracts: Improve contract address derivation#12883
paritytech-processbot[bot] merged 14 commits intomasterfrom
at/contract-addr

athei commented Dec 9, 2022 •

edited

Loading

Uh oh!

athei commented Dec 9, 2022

Uh oh!

command-bot bot commented Dec 9, 2022 •

edited

Loading

Uh oh!

command-bot bot commented Dec 9, 2022

Uh oh!

athei commented Dec 9, 2022

Uh oh!

command-bot bot commented Dec 9, 2022 •

edited

Loading

Uh oh!

command-bot bot commented Dec 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

athei commented Dec 22, 2022

Uh oh!

paritytech-processbot bot commented Dec 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

athei commented Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

athei commented Dec 9, 2022

Uh oh!

command-bot bot commented Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 9, 2022

Uh oh!

athei commented Dec 9, 2022

Uh oh!

command-bot bot commented Dec 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

athei commented Dec 22, 2022

Uh oh!

paritytech-processbot bot commented Dec 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

athei commented Dec 9, 2022 •

edited

Loading

command-bot bot commented Dec 9, 2022 •

edited

Loading

command-bot bot commented Dec 9, 2022 •

edited

Loading