Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Referenda benchmark assert fix#12866

Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom
muharem-fix-referenda-bench
Dec 7, 2022
Merged

Referenda benchmark assert fix#12866
paritytech-processbot[bot] merged 1 commit intomasterfrom
muharem-fix-referenda-bench

Conversation

@muharem
Copy link
Copy Markdown
Contributor

@muharem muharem commented Dec 7, 2022

if SubmissionDeposit is zero, the assertion fails.

polkadot companion: paritytech/polkadot#6360

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 7, 2022
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Dec 7, 2022

bot merge

@paritytech-processbot
Copy link
Copy Markdown

Waiting for commit status.

@paritytech-processbot
Copy link
Copy Markdown

Merge cancelled due to error. Error: Statuses failed for 0e2a857

@muharem
Copy link
Copy Markdown
Contributor Author

muharem commented Dec 7, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 0a27e54 into master Dec 7, 2022
@paritytech-processbot paritytech-processbot bot deleted the muharem-fix-referenda-bench branch December 7, 2022 13:57
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants