This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make Gov2 Curve::threshold fn public#12814
Merged
bkchr merged 1 commit intoparitytech:masterfrom Dec 5, 2022
Merged
Conversation
ggwpez
approved these changes
Dec 1, 2022
ggwpez
added
A0-please_review
bkchr
approved these changes
Dec 5, 2022
Member
|
bot merge |
|
Error: Checks failed for 5bd2a05 |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curve::thresholdfunction returns theyvalue for a givenxvalue on the Gov2 Curve object. This PR changes its visibility frompub(crate)topub.Moonbeam is using this function to chart and compare approval/support curves. Currently we have copied pasted the function definition https://github.com/4meta5/gov2-curve-plotter/blob/main/src/curve.rs#L179-L202 but would prefer to call it directly which requires making it public.