[contracts] Add per local weight for function call by agryaznov · Pull Request #12806 · paritytech/substrate

agryaznov · 2022-11-29T19:23:22Z

Limit the number of locals a function can have
Additional weight for calling a function per local that function has

agryaznov · 2022-11-29T19:49:48Z

/cmd queue -c bench-bot $ pallet dev pallet_contracts

command-bot · 2022-11-29T19:49:52Z

@agryaznov https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2099630 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 75-2ecce2c1-5a8c-4875-90ec-36b70bd4a9cc to cancel this command or /cmd cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2022-11-29T21:37:14Z

@agryaznov Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2099630 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2099630/artifacts/download.

frame/contracts/src/schedule.rs

frame/contracts/src/benchmarking/mod.rs

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

agryaznov · 2022-11-30T13:43:00Z

/cmd queue -c bench-bot $ pallet dev pallet_contracts

command-bot · 2022-11-30T13:43:05Z

@agryaznov https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2102326 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 76-db3ef99b-a526-4bc7-9b92-3aece8ed7496 to cancel this command or /cmd cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2022-11-30T15:15:54Z

@agryaznov Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2102326 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2102326/artifacts/download.

frame/contracts/src/benchmarking/mod.rs

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

agryaznov · 2022-12-01T18:47:34Z

/cmd queue -c bench-bot $ pallet dev pallet_contracts

command-bot · 2022-12-01T18:47:38Z

@agryaznov https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108275 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 79-d8e1f80c-b3f6-4501-b4a3-6472753c7bd0 to cancel this command or /cmd cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2022-12-01T20:37:28Z

@agryaznov Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108275 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108275/artifacts/download.

agryaznov · 2022-12-01T20:46:17Z

/cmd queue -c bench-bot $ pallet dev pallet_contracts

command-bot · 2022-12-01T20:46:21Z

@agryaznov https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108952 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 80-34efdd00-4b09-490b-8b95-f81a78b7808e to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot · 2022-12-01T22:31:32Z

@agryaznov Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108952 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108952/artifacts/download.

xermicus

LGTM

athei · 2022-12-06T09:52:04Z

bot merge

* Add per local weight for function call * ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts * Update frame/contracts/src/benchmarking/mod.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * apply suggestions from code review * ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts * Update frame/contracts/src/benchmarking/mod.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * tune the benchmark * ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts * fix benches * ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts Co-authored-by: command-bot <> Co-authored-by: Alexander Theißen <alex.theissen@me.com>

Add per local weight for function call

be8e5b5

agryaznov added the A0-please_review Pull request needs code review. label Nov 29, 2022

github-actions bot added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Nov 29, 2022

agryaznov marked this pull request as ready for review November 29, 2022 19:37

agryaznov requested a review from athei as a code owner November 29, 2022 19:37

command-bot added 2 commits November 29, 2022 19:50

Merge branch 'master' of https://github.com/paritytech/substrate into…

fdb6f1c

… HEAD

".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

2760eeb

athei added the B0-silent Changes should not be mentioned in any release notes label Nov 30, 2022

athei suggested changes Nov 30, 2022

View reviewed changes

frame/contracts/src/schedule.rs Outdated Show resolved Hide resolved

frame/contracts/src/benchmarking/mod.rs Outdated Show resolved Hide resolved

agryaznov and others added 2 commits November 30, 2022 14:37

Update frame/contracts/src/benchmarking/mod.rs

7704d1f

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

apply suggestions from code review

51fdfe1

Merge branch 'master' of https://github.com/paritytech/substrate into…

14754a3

… HEAD

athei requested a review from xermicus November 30, 2022 15:07

".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

08855f7

athei reviewed Nov 30, 2022

View reviewed changes

frame/contracts/src/benchmarking/mod.rs Outdated Show resolved Hide resolved

frame/contracts/src/benchmarking/mod.rs Show resolved Hide resolved

agryaznov and others added 2 commits December 1, 2022 13:41

Update frame/contracts/src/benchmarking/mod.rs

4bc127b

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

tune the benchmark

60276c4

command-bot added 2 commits December 1, 2022 19:05

Merge branch 'master' of https://github.com/paritytech/substrate into…

9e197ac

… HEAD

".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

d9cc82a

fix benches

7f15541

".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

aae6c1e

agryaznov requested a review from athei December 2, 2022 10:23

xermicus approved these changes Dec 2, 2022

View reviewed changes

athei approved these changes Dec 6, 2022

View reviewed changes

paritytech-processbot bot merged commit fa42631 into master Dec 6, 2022

paritytech-processbot bot deleted the ag-limit-locals branch December 6, 2022 09:52

aurexav mentioned this pull request Jan 10, 2023

To polkadot-v0.9.36 darwinia-network/darwinia-2.0#193

Closed

kacperzuk-neti mentioned this pull request Jan 23, 2023

Update to polkadot 0.9.34 liberland/liberland_substrate#225

Merged

Conversation

agryaznov commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agryaznov commented Nov 29, 2022

Uh oh!

command-bot bot commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Nov 29, 2022

Uh oh!

Uh oh!

Uh oh!

agryaznov commented Nov 30, 2022

Uh oh!

command-bot bot commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Nov 30, 2022

Uh oh!

Uh oh!

Uh oh!

agryaznov commented Dec 1, 2022

Uh oh!

command-bot bot commented Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 1, 2022

Uh oh!

agryaznov commented Dec 1, 2022

Uh oh!

command-bot bot commented Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Dec 1, 2022

Uh oh!

xermicus left a comment

Choose a reason for hiding this comment

Uh oh!

athei commented Dec 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agryaznov commented Nov 29, 2022 •

edited

Loading

command-bot bot commented Nov 29, 2022 •

edited

Loading

command-bot bot commented Nov 30, 2022 •

edited

Loading

command-bot bot commented Dec 1, 2022 •

edited

Loading

command-bot bot commented Dec 1, 2022 •

edited

Loading