This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
bkchr
approved these changes
Dec 6, 2021
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Besides the test, it looks good to me.
bkchr
added
A0-please_review
tomusdrw
approved these changes
Dec 6, 2021
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
Note this is only for priority calculations and yeah, perhaps it is more elegant to add one than to have a minimum value.
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* allow tip value of 1 * update comment * fmt * update test * fmt
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* allow tip value of 1 * update comment * fmt * update test * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously tip value of 1 is same as zero. Now it actually makes difference.
Not important at all so feel free to close this one if you think the previous behavior is ok.