Add baseline benchmark for sr25519 verification by emostov · Pull Request #10414 · paritytech/substrate

emostov · 2021-12-02T20:05:01Z

The weight of sr25519 signature verification is a major factor in the performance of the polkadot parachains runtime enter inherent and its creation.

skip cumulus-dependent-check

emostov · 2021-12-02T20:05:30Z

/benchmark runtime pallet frame_benchmarking

parity-benchapp · 2021-12-02T20:21:09Z

Benchmark Runtime Pallet for branch "zeke-bench-sig-verification" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

Pallet: "frame_benchmarking", Extrinsic: "addition", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    0.283
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     0.281     0.007    2.4%
20000     0.274     0.006    2.1%
40000     0.291     0.011    3.7%
60000     0.285     0.009    3.1%
80000      0.27     0.008    2.9%
100000     0.281     0.008    2.8%
120000     0.279     0.006    2.1%
140000     0.281     0.006    2.1%
160000     0.273     0.006    2.1%
180000     0.285     0.006    2.1%
200000      0.28     0.009    3.2%
220000     0.303     0.005    1.6%
240000     0.285     0.006    2.1%
260000     0.289     0.005    1.7%
280000     0.282     0.004    1.4%
300000      0.29     0.003    1.0%
320000     0.292     0.007    2.3%
340000     0.285     0.006    2.1%
360000     0.287     0.009    3.1%
380000     0.287     0.009    3.1%
400000      0.29     0.009    3.1%
420000     0.291     0.011    3.7%
440000      0.29     0.006    2.0%
460000     0.281     0.004    1.4%
480000     0.287     0.006    2.0%
500000     0.275     0.009    3.2%
520000     0.294     0.012    4.0%
540000     0.289     0.006    2.0%
560000      0.27     0.007    2.5%
580000     0.277     0.005    1.8%
600000     0.272     0.006    2.2%
620000     0.267     0.004    1.4%
640000     0.273     0.007    2.5%
660000     0.283     0.007    2.4%
680000     0.283     0.007    2.4%
700000     0.273     0.009    3.2%
720000     0.271     0.004    1.4%
740000     0.274     0.006    2.1%
760000     0.285     0.006    2.1%
780000     0.272     0.009    3.3%
800000     0.283     0.007    2.4%
820000     0.288     0.009    3.1%
840000      0.29     0.008    2.7%
860000     0.295     0.004    1.3%
880000     0.278     0.006    2.1%
900000      0.28     0.009    3.2%
920000      0.28     0.008    2.8%
940000     0.285     0.005    1.7%
960000     0.284      0.01    3.5%
980000     0.277     0.009    3.2%
1000000     0.283     0.006    2.1%

Quality and confidence:
param     error
i             0

Model:
Time ~=    0.284
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Pallet: "frame_benchmarking", Extrinsic: "subtraction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=     0.28
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     0.283     0.006    2.1%
20000     0.269     0.003    1.1%
40000     0.282     0.005    1.7%
60000     0.267     0.005    1.8%
80000     0.278     0.006    2.1%
100000     0.278     0.005    1.7%
120000      0.29     0.003    1.0%
140000     0.288     0.004    1.3%
160000     0.293     0.005    1.7%
180000     0.282     0.004    1.4%
200000     0.275      0.01    3.6%
220000     0.293     0.006    2.0%
240000     0.277     0.007    2.5%
260000     0.281     0.009    3.2%
280000      0.27     0.007    2.5%
300000     0.276     0.005    1.8%
320000     0.274     0.007    2.5%
340000     0.281     0.009    3.2%
360000     0.295     0.008    2.7%
380000     0.283     0.006    2.1%
400000     0.273     0.007    2.5%
420000     0.282     0.005    1.7%
440000     0.272     0.005    1.8%
460000     0.271     0.006    2.2%
480000     0.279     0.007    2.5%
500000     0.271     0.005    1.8%
520000     0.282     0.006    2.1%
540000     0.276     0.012    4.3%
560000     0.284     0.011    3.8%
580000     0.265     0.006    2.2%
600000     0.281     0.007    2.4%
620000      0.27     0.004    1.4%
640000     0.277     0.009    3.2%
660000     0.281     0.008    2.8%
680000     0.281     0.005    1.7%
700000     0.286     0.005    1.7%
720000     0.267     0.004    1.4%
740000     0.288     0.015    5.2%
760000     0.279      0.01    3.5%
780000     0.285     0.008    2.8%
800000     0.271     0.007    2.5%
820000     0.294     0.007    2.3%
840000      0.26     0.003    1.1%
860000     0.274     0.007    2.5%
880000     0.286     0.007    2.4%
900000     0.286     0.005    1.7%
920000     0.281     0.004    1.4%
940000     0.309     0.008    2.5%
960000     0.286     0.004    1.3%
980000      0.28     0.008    2.8%
1000000     0.275     0.005    1.8%

Quality and confidence:
param     error
i             0

Model:
Time ~=    0.279
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Pallet: "frame_benchmarking", Extrinsic: "multiplication", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    0.277
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     0.265     0.004    1.5%
20000     0.273     0.005    1.8%
40000     0.267     0.005    1.8%
60000      0.26     0.004    1.5%
80000     0.276     0.006    2.1%
100000      0.29     0.004    1.3%
120000     0.302     0.008    2.6%
140000     0.278     0.007    2.5%
160000     0.291     0.008    2.7%
180000     0.266     0.004    1.5%
200000     0.274     0.008    2.9%
220000      0.27     0.009    3.3%
240000     0.281     0.003    1.0%
260000     0.286     0.004    1.3%
280000      0.28     0.005    1.7%
300000     0.273     0.003    1.0%
320000     0.274     0.004    1.4%
340000     0.273     0.005    1.8%
360000     0.267     0.005    1.8%
380000     0.283     0.007    2.4%
400000     0.284     0.011    3.8%
420000     0.275     0.008    2.9%
440000     0.277     0.008    2.8%
460000      0.27     0.005    1.8%
480000     0.274     0.006    2.1%
500000     0.268     0.003    1.1%
520000     0.278      0.01    3.5%
540000     0.272     0.012    4.4%
560000     0.289     0.008    2.7%
580000     0.292     0.005    1.7%
600000      0.28     0.008    2.8%
620000     0.293     0.009    3.0%
640000     0.286     0.007    2.4%
660000      0.28     0.007    2.5%
680000     0.282     0.006    2.1%
700000     0.286     0.006    2.0%
720000     0.288     0.009    3.1%
740000     0.274     0.005    1.8%
760000     0.272     0.005    1.8%
780000     0.271     0.004    1.4%
800000     0.275     0.008    2.9%
820000     0.272     0.005    1.8%
840000     0.262     0.004    1.5%
860000     0.261     0.005    1.9%
880000      0.28     0.012    4.2%
900000     0.271     0.007    2.5%
920000     0.272     0.005    1.8%
940000     0.272     0.008    2.9%
960000     0.289     0.004    1.3%
980000     0.262     0.007    2.6%
1000000     0.275     0.004    1.4%

Quality and confidence:
param     error
i             0

Model:
Time ~=    0.278
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Pallet: "frame_benchmarking", Extrinsic: "division", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    0.273
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     0.271     0.011    4.0%
20000     0.288     0.009    3.1%
40000     0.277     0.009    3.2%
60000     0.257     0.005    1.9%
80000     0.275     0.008    2.9%
100000     0.267     0.005    1.8%
120000      0.28     0.006    2.1%
140000     0.279     0.007    2.5%
160000     0.263     0.003    1.1%
180000      0.28     0.009    3.2%
200000     0.272     0.005    1.8%
220000      0.27     0.007    2.5%
240000     0.275     0.006    2.1%
260000     0.273     0.006    2.1%
280000      0.28     0.019    6.7%
300000     0.259     0.007    2.7%
320000     0.265     0.007    2.6%
340000      0.28      0.01    3.5%
360000     0.276     0.009    3.2%
380000     0.281     0.004    1.4%
400000     0.271     0.005    1.8%
420000     0.271     0.005    1.8%
440000     0.289     0.011    3.8%
460000      0.28     0.005    1.7%
480000     0.273     0.007    2.5%
500000      0.28     0.004    1.4%
520000     0.275     0.006    2.1%
540000     0.267     0.006    2.2%
560000     0.281     0.006    2.1%
580000     0.293      0.01    3.4%
600000     0.278     0.006    2.1%
620000     0.271     0.005    1.8%
640000     0.278     0.005    1.7%
660000     0.277     0.004    1.4%
680000     0.278     0.005    1.7%
700000     0.275     0.006    2.1%
720000     0.268     0.008    2.9%
740000      0.28     0.005    1.7%
760000     0.286     0.009    3.1%
780000     0.269     0.004    1.4%
800000     0.288     0.008    2.7%
820000     0.279     0.013    4.6%
840000     0.285     0.009    3.1%
860000      0.27     0.005    1.8%
880000     0.263     0.006    2.2%
900000     0.286     0.007    2.4%
920000     0.268     0.007    2.6%
940000     0.264     0.004    1.5%
960000     0.274     0.005    1.8%
980000     0.275     0.007    2.5%
1000000     0.288     0.012    4.1%

Quality and confidence:
param     error
i             0

Model:
Time ~=    0.274
    + i        0
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Pallet: "frame_benchmarking", Extrinsic: "hashing", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    33290
    + i    0.074
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     33350     254.8    0.7%
    2     33400     195.7    0.5%
    4     33180     38.81    0.1%
    6     33960     64.02    0.1%
    8     33170     37.87    0.1%
   10     33970      31.5    0.0%
   12     33220     71.69    0.2%
   14     33990     111.5    0.3%
   16     33890     45.97    0.1%
   18     33170     47.69    0.1%
   20     33130     53.67    0.1%
   22     33260     80.36    0.2%
   24     33330     274.4    0.8%
   26     33930     36.32    0.1%
   28     33110     33.35    0.1%
   30     33220     131.3    0.3%
   32     33120     51.35    0.1%
   34     33310     214.4    0.6%
   36     33920     64.95    0.1%
   38     33110     34.72    0.1%
   40     33110     18.45    0.0%
   42     33630     242.1    0.7%
   44     33870      79.8    0.2%
   46     33150     53.64    0.1%
   48     33160      49.7    0.1%
   50     33200     40.16    0.1%
   52     33930      34.3    0.1%
   54     33180     42.42    0.1%
   56     33820     61.51    0.1%
   58     33160     43.33    0.1%
   60     33550     304.3    0.9%
   62     33250     25.09    0.0%
   64     33140     26.94    0.0%
   66     33850     47.91    0.1%
   68     33110      40.3    0.1%
   70     33880     39.95    0.1%
   72     33880     35.96    0.1%
   74     33900     36.91    0.1%
   76     33150     37.73    0.1%
   78     33780     161.4    0.4%
   80     33150     48.16    0.1%
   82     33660     294.7    0.8%
   84     33300     108.5    0.3%
   86     33950     133.7    0.3%
   88     33150     31.19    0.0%
   90     33870     32.07    0.0%
   92     33120     21.23    0.0%
   94     33340     226.5    0.6%
   96     33130     74.43    0.2%
   98     33210     76.72    0.2%
  100     33890     69.94    0.2%

Quality and confidence:
param     error
i         0.535

Model:
Time ~=    33440
    + i    0.363
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Pallet: "frame_benchmarking", Extrinsic: "sr25519_verification", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    2.384
    + i    47.94
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    1     50.19      0.14    0.2%
    2     98.49     0.316    0.3%
    3     146.1      0.25    0.1%
    4     194.2     0.256    0.1%
    5     241.9     0.209    0.0%
    6     289.7     0.331    0.1%
    7     337.5     0.485    0.1%
    8     385.2     0.413    0.1%
    9     433.3     0.565    0.1%
   10     480.7      0.58    0.1%
   11     529.5     0.565    0.1%
   12       577     1.176    0.2%
   13     623.9       0.4    0.0%
   14     673.1     1.018    0.1%
   15     722.6     5.422    0.7%
   16     767.3     0.828    0.1%
   17     815.3     1.159    0.1%
   18     870.9      11.2    1.2%
   19     916.1     9.703    1.0%
   20     960.1     1.211    0.1%
   21      1008     1.894    0.1%
   22      1064     12.71    1.1%
   23      1110     10.99    0.9%
   24      1150     0.923    0.0%
   25      1205     11.08    0.9%
   26      1247     3.841    0.3%
   27      1300     10.16    0.7%
   28      1341     1.402    0.1%
   29      1392     5.747    0.4%
   30      1451     16.32    1.1%
   31      1489     8.643    0.5%
   32      1559     13.88    0.8%
   33      1581     2.087    0.1%
   34      1633     9.782    0.5%
   35      1684      12.9    0.7%
   36      1732     11.68    0.6%
   37      1790     12.64    0.7%
   38      1822     7.263    0.3%
   39      1877     14.27    0.7%
   40      1928     13.19    0.6%
   41      1978     12.04    0.6%
   42      2012     2.564    0.1%
   43      2065     12.13    0.5%
   44      2118     11.93    0.5%
   45      2158      6.17    0.2%
   46      2223      14.3    0.6%
   47      2265     13.93    0.6%
   48      2316     13.95    0.6%
   49      2358     12.62    0.5%
   50      2401     10.19    0.4%
   51      2452     14.52    0.5%
   52      2512     13.53    0.5%
   53      2549     12.44    0.4%
   54      2594     12.84    0.4%
   55      2646     13.52    0.5%
   56      2692     13.14    0.4%
   57      2743     14.45    0.5%
   58      2791     13.18    0.4%
   59      2836      11.4    0.4%
   60      2885      12.1    0.4%
   61      2949      13.1    0.4%
   62      2997     8.216    0.2%
   63      3032     10.43    0.3%
   64      3081      11.2    0.3%
   65      3128     18.95    0.6%
   66      3190     20.03    0.6%
   67      3235     20.46    0.6%
   68      3285     11.57    0.3%
   69      3316     14.86    0.4%
   70      3363      11.4    0.3%
   71      3427     10.17    0.2%
   72      3449     9.523    0.2%
   73      3508     13.08    0.3%
   74      3558     11.79    0.3%
   75      3603     13.97    0.3%
   76      3658     13.21    0.3%
   77      3721     15.22    0.4%
   78      3758     12.22    0.3%
   79      3802     14.24    0.3%
   80      3843     12.64    0.3%
   81      3899     11.95    0.3%
   82      3958     11.86    0.2%
   83      3995     14.57    0.3%
   84      4047     2.899    0.0%
   85      4094     3.461    0.0%
   86      4143     17.83    0.4%
   87      4183     8.947    0.2%
   88      4233     12.06    0.2%
   89      4289     23.88    0.5%
   90      4331     9.986    0.2%
   91      4380     14.75    0.3%
   92      4435     17.29    0.3%
   93      4475     13.37    0.2%
   94      4551     30.25    0.6%
   95      4571     11.74    0.2%
   96      4614     13.09    0.2%
   97      4656      17.1    0.3%
   98      4721     19.97    0.4%
   99      4770     20.01    0.4%
  100      4809     12.64    0.2%

Quality and confidence:
param     error
i         0.014

Model:
Time ~=    0.026
    + i    48.15
              µs

Reads = 0 + (0 * i)
Writes = 0 + (0 * i)

Pallet: "frame_benchmarking", Extrinsic: "storage_read", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Skipped Metadata (r:0 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + i    2.678
              µs

Reads = 0 + (1 * i)
Writes = 0 + (0 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     0.279      0.01    3.5%
   20     45.54     0.064    0.1%
   40     91.45     0.222    0.2%
   60     137.6     0.259    0.1%
   80     183.9     0.904    0.4%
  100     229.2     0.906    0.3%
  120     278.1     1.441    0.5%
  140     330.6     1.272    0.3%
  160     373.8     0.955    0.2%
  180     423.8     1.971    0.4%
  200     477.2     1.518    0.3%
  220     529.1     5.325    1.0%
  240       596     11.08    1.8%
  260     649.4     1.853    0.2%
  280     700.8     1.617    0.2%
  300     746.1      6.48    0.8%
  320     799.2     8.408    1.0%
  340     841.3      7.71    0.9%
  360     895.2     8.519    0.9%
  380     949.5     7.855    0.8%
  400     987.2     6.052    0.6%
  420      1045     15.39    1.4%
  440      1098     11.54    1.0%
  460      1196     13.69    1.1%
  480      1219     9.352    0.7%
  500      1272     7.975    0.6%
  520      1305     9.974    0.7%
  540      1385     17.74    1.2%
  560      1430     8.886    0.6%
  580      1498     6.026    0.4%
  600      1540     10.03    0.6%
  620      1605     14.45    0.9%
  640      1645     12.02    0.7%
  660      1727     13.26    0.7%
  680      1743     13.77    0.7%
  700      1834     10.57    0.5%
  720      1868         7    0.3%
  740      1919     15.66    0.8%
  760      1976     8.574    0.4%
  780      2035     16.29    0.8%
  800      2085     12.02    0.5%
  820      2175      11.6    0.5%
  840      2194     22.72    1.0%
  860      2272     12.28    0.5%
  880      2330      10.5    0.4%
  900      2415     18.29    0.7%
  920      2464        16    0.6%
  940      2501     18.22    0.7%
  960      2566     14.12    0.5%
  980      2625     14.68    0.5%
 1000      2681     16.77    0.6%

Quality and confidence:
param     error
i         0.004

Model:
Time ~=        0
    + i    2.694
              µs

Reads = 0 + (1 * i)
Writes = 0 + (0 * i)

Pallet: "frame_benchmarking", Extrinsic: "storage_write", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Skipped Metadata (r:0 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + i    0.602
              µs

Reads = 0 + (0 * i)
Writes = 0 + (1 * i)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    i   mean µs  sigma µs       %
    0     0.299     0.006    2.0%
   20     11.66     0.202    1.7%
   40     23.44     0.093    0.3%
   60     35.04     0.451    1.2%
   80     45.37     0.099    0.2%
  100      57.2     0.161    0.2%
  120      70.1       1.4    1.9%
  140     80.84     0.173    0.2%
  160     92.83     0.207    0.2%
  180     104.2     0.298    0.2%
  200     116.3     0.264    0.2%
  220     129.5     2.228    1.7%
  240     141.6     1.777    1.2%
  260     153.9     1.175    0.7%
  280     163.8     0.116    0.0%
  300     175.7     0.305    0.1%
  320     189.1     1.737    0.9%
  340     201.2     1.195    0.5%
  360     211.4     0.567    0.2%
  380     222.6     0.332    0.1%
  400     236.6      2.43    1.0%
  420     245.9     0.428    0.1%
  440     257.2      0.81    0.3%
  460     270.5     0.586    0.2%
  480     283.9     0.699    0.2%
  500     294.3      0.48    0.1%
  520     305.7     0.963    0.3%
  540     319.6     0.864    0.2%
  560     333.4     3.907    1.1%
  580     342.6     0.728    0.2%
  600     360.4     7.673    2.1%
  620     372.2     7.922    2.1%
  640     380.3     1.646    0.4%
  660     392.9     2.447    0.6%
  680     405.6     6.072    1.4%
  700       416     0.624    0.1%
  720     428.8     4.376    1.0%
  740     445.3     4.915    1.1%
  760     452.5     1.015    0.2%
  780     465.4      1.55    0.3%
  800     477.7     0.516    0.1%
  820     489.9     0.523    0.1%
  840     507.7     8.324    1.6%
  860     516.6     1.158    0.2%
  880       531     1.016    0.1%
  900     547.4     5.547    1.0%
  920     559.2     7.931    1.4%
  940     567.5     1.405    0.2%
  960     582.5     3.417    0.5%
  980     589.7      0.77    0.1%
 1000     607.3     4.503    0.7%

Quality and confidence:
param     error
i             0

Model:
Time ~=        0
    + i    0.606
              µs

Reads = 0 + (0 * i)
Writes = 0 + (1 * i)

…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs

shawntabrizi · 2021-12-02T20:35:25Z

frame/benchmarking/src/baseline.rs

+			assert_eq!(
+				sig.verify(&msg[..], &public),
+				true


would be good to verify that this is exactly what we want to measure versus a batch signature verification?

I am most interested in the speed of a single verification like this https://github.com/paritytech/polkadot/blob/5afceea8b77d27ac6c3eaf500160e9f34807c26b/runtime/parachains/src/disputes.rs#L1221

sounds good then

…tytech/substrate into zeke-bench-sig-verification

frame/benchmarking/src/baseline.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

emostov · 2021-12-06T19:11:34Z

bot merge

paritytech-processbot · 2021-12-06T19:11:42Z

Error: Checks failed for 4271764

drahnr · 2021-12-06T21:28:57Z

bot merge

paritytech-processbot · 2021-12-06T21:29:09Z

Error: Checks failed for 4271764

* Add baseline benchmark for sr25519 verification * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs * Register keystore for correct test externalities * Update frame/benchmarking/src/baseline.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * fix build Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Add baseline benchmark for sr25519 verification

39d25fa

github-actions bot added the A0-please_review Pull request needs code review. label Dec 2, 2021

emostov added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Dec 2, 2021

shawntabrizi reviewed Dec 2, 2021

View reviewed changes

shawntabrizi approved these changes Dec 2, 2021

View reviewed changes

emostov added 2 commits December 2, 2021 13:16

Register keystore for correct test externalities

a3553af

Merge branch 'zeke-bench-sig-verification' of https://github.com/pari…

4025f2e

…tytech/substrate into zeke-bench-sig-verification

emostov requested a review from drahnr December 2, 2021 21:18

bkchr approved these changes Dec 2, 2021

View reviewed changes

frame/benchmarking/src/baseline.rs Outdated Show resolved Hide resolved

emostov and others added 2 commits December 2, 2021 15:19

Update frame/benchmarking/src/baseline.rs

8620d35

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

fix build

4271764

drahnr approved these changes Dec 3, 2021

View reviewed changes

bkchr merged commit f0b85c6 into master Dec 6, 2021

bkchr deleted the zeke-bench-sig-verification branch December 6, 2021 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add baseline benchmark for sr25519 verification#10414

Add baseline benchmark for sr25519 verification#10414
bkchr merged 6 commits intomasterfrom
zeke-bench-sig-verification

emostov commented Dec 2, 2021 •

edited by drahnr

Loading

Uh oh!

emostov commented Dec 2, 2021

Uh oh!

parity-benchapp bot commented Dec 2, 2021 •

edited

Loading

Uh oh!

shawntabrizi Dec 2, 2021

Uh oh!

emostov Dec 2, 2021 •

edited

Loading

Uh oh!

shawntabrizi Dec 2, 2021

Uh oh!

Uh oh!

emostov commented Dec 6, 2021

Uh oh!

paritytech-processbot bot commented Dec 6, 2021

Uh oh!

drahnr commented Dec 6, 2021

Uh oh!

paritytech-processbot bot commented Dec 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

emostov commented Dec 2, 2021 • edited by drahnr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emostov commented Dec 2, 2021

Uh oh!

parity-benchapp bot commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawntabrizi Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

emostov Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawntabrizi Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emostov commented Dec 6, 2021

Uh oh!

paritytech-processbot bot commented Dec 6, 2021

Uh oh!

drahnr commented Dec 6, 2021

Uh oh!

paritytech-processbot bot commented Dec 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emostov commented Dec 2, 2021 •

edited by drahnr

Loading

parity-benchapp bot commented Dec 2, 2021 •

edited

Loading

emostov Dec 2, 2021 •

edited

Loading