This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Reduce the execution time of some tests#10377
Merged
paritytech-processbot[bot] merged 4 commits intomasterfrom Nov 28, 2021
Merged
Reduce the execution time of some tests#10377paritytech-processbot[bot] merged 4 commits intomasterfrom
paritytech-processbot[bot] merged 4 commits intomasterfrom
Conversation
kianenigma
added
A0-please_review
bkchr
approved these changes
Nov 26, 2021
kianenigma
added
A2-insubstantial
emostov
approved these changes
Nov 28, 2021
Contributor
Author
|
bot merge |
|
Error: It's not possible to meet the minimal approval count of 1 in paritytech/polkadot#4379 |
Member
|
bot merge |
paritytech-processbot
bot
deleted the
kiz-tame-bench-test-execution-times
branch
chevdor
pushed a commit
that referenced
this pull request
Dec 1, 2021
* Reduce the execution time of some tests * Fix * Fix build * fmt
chevdor
pushed a commit
that referenced
this pull request
Jan 11, 2022
* Reduce the execution time of some tests * Fix * Fix build * fmt
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Reduce the execution time of some tests * Fix * Fix build * fmt
aurexav
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Reduce the execution time of some tests * Fix * Fix build * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some tests where were taking an unreasonably long duration on my machine. Turned out they had constant configurations that implied so, so I changed them.
Example:
bench_get_npos_targetsdebug build before: <idk, it just takes forever, more than a few minutes 🤷>bench_get_npos_targetsdebug build after: 2.92sbench_get_npos_targetsrelease build before: 0.58sbench_get_npos_targetsrelease build after: 0.06spallet_election_provider_multi_phaseall tests debug before: 23.92spallet_election_provider_multi_phaseall tests debug after: 0.42sluckily the CI is running tests in release, so less of a big deal.
polkadot companion: paritytech/polkadot#4379
skip check-dependent-cumulus