Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

CI: remove node-template from build-linux-substrate-simnet job#10034

Merged
alvicsam merged 3 commits intomasterfrom
as-fix-simnet-quick-test
Oct 18, 2021
Merged

CI: remove node-template from build-linux-substrate-simnet job#10034
alvicsam merged 3 commits intomasterfrom
as-fix-simnet-quick-test

Conversation

@alvicsam
Copy link
Copy Markdown
Contributor

Removed building substrate-node-template.tar.gz in build-linux-substrate-simnet since it's not required to build temporary docker image and it caused pipeline failures

@alvicsam alvicsam added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 15, 2021
@alvicsam alvicsam requested review from a team, TriplEight and bkchr October 15, 2021 09:30
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 15, 2021

The code is still there?

@alvicsam
Copy link
Copy Markdown
Contributor Author

Sure, I only removed building it as an artifact in job related to simnet quick tests

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 15, 2021

I'm confused, the title says "remove ...", but you only add code? xD

@alvicsam alvicsam changed the title CI: remove node-template from build-linux-substrate-simnet CI: remove node-template from build-linux-substrate-simnet job Oct 15, 2021
@alvicsam
Copy link
Copy Markdown
Contributor Author

Fixed the title :)

Explanation about added lines:
There are 2 tasks: build-linux-substrate and build-linux-substrate-simnet.
build-linux-substrate runs only on master branch or when a tag is assigned. It builds substrate and runs node-template.

build-linux-substrate-simnet was added in #9959 and used build-linux-substrate as a template (including script part). Since this step is needed only to create a substrate binary which will be injected to a docker image for quick simnet tests I removed steps related to node-template. In order to do that I needed to override script section.

Copy link
Copy Markdown
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for the explanation! Now it makes sense! :)

@alvicsam alvicsam requested a review from TriplEight October 15, 2021 13:19
@alvicsam alvicsam force-pushed the as-fix-simnet-quick-test branch from fe82ead to f66cdd6 Compare October 15, 2021 15:10
@alvicsam alvicsam force-pushed the as-fix-simnet-quick-test branch from f66cdd6 to cf88cb3 Compare October 15, 2021 15:15
@alvicsam alvicsam merged commit 129c16b into master Oct 18, 2021
@alvicsam alvicsam deleted the as-fix-simnet-quick-test branch October 18, 2021 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants