Skip to content

Disable referendum link creation #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mutantcornholio merged 2 commits into from
Sep 2, 2024
Merged

Disable referendum link creation #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1b2436
disable link creation for now
rzadp Sep 2, 2024
1327682
lint
rzadp Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/bot-handle-comment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { ss58Address } from "@polkadot-labs/hdkd-helpers";
import { updateBalance } from "./balance";
import { matrixNotifyOnFailure, matrixNotifyOnNewTip } from "./matrix";
import { recordTip } from "./metrics";
import { tipUser, tipUserLink } from "./tip";
import { tipUser } from "./tip";
import { updatePolkassemblyPost } from "./tip-opengov";
import { GithubReactionType, State, TipRequest, TipResult } from "./types";
import { formatTipSize, getTipSize, parseContributorAccount } from "./util";
Expand Down Expand Up @@ -166,17 +166,18 @@ export const handleTipRequest = async (
{ octokitInstance },
))
) {
let createReferendumLink: string | undefined = undefined;
try {
const tipLink = await tipUserLink(state, tipRequest);
if (!tipLink.success) {
throw new Error(tipLink.errorMessage);
}
createReferendumLink = tipLink.extrinsicCreationLink;
} catch (e) {
bot.log.error("Failed to encode and create a link to tip referendum creation.");
bot.log.error(e.message);
}
let createReferendumLink: string | undefined;
// TODO: Broken after PAPI migration. https://github.com/paritytech/substrate-tip-bot/issues/170
// try {
// const tipLink = await tipUserLink(state, tipRequest);
// if (!tipLink.success) {
// throw new Error(tipLink.errorMessage);
// }
// createReferendumLink = tipLink.extrinsicCreationLink;
// } catch (e) {
// bot.log.error("Failed to encode and create a link to tip referendum creation.");
// bot.log.error(e.message);
// }

let message =
`Only members of \`${allowedGitHubOrg}/${allowedGitHubTeam}\` ` +
Expand Down