Change type id to new type id in PortableRegistry::retain().#204
Merged
Change type id to new type id in PortableRegistry::retain().#204
PortableRegistry::retain().#204Conversation
jsdw
reviewed
Mar 22, 2024
Contributor
jsdw
left a comment
jsdw
left a comment
There was a problem hiding this comment.
One small thing; this was missed in our retain tests before, so could we tweak the tests to make sure this works too? :)
jsdw
approved these changes
Mar 22, 2024
niklasad1
approved these changes
Mar 22, 2024
lexnv
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type's id should be set to the new id to reflect the correct position in the
Vecholding the types of thePortableRegistry.See the comment of @jsdw here: paritytech/scale-typegen#23 (comment)