Merged
Conversation
dvdplm
approved these changes
Jun 23, 2021
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
My only concern is whether we should include the docs feature in the defaults or not. I'd be inclined to include it by default.
derive/Cargo.toml
Outdated
Comment on lines
+24
to
+26
| default = [] | ||
| # Include code docs in type metadata. | ||
| docs = [] |
Contributor
There was a problem hiding this comment.
Wouldn't we want the docs to be included by default? In the steady-state future scenario we'll want the full metadata I think, and excluding it is something we want to do only while figuring out where to store it yes?
Co-authored-by: David <dvdplm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs will not be generated by the proc macro unless the
docsfeature is enabled.This allows reducing the size of the metadata code, useful for substrate runtimes: paritytech/substrate#8370 (comment)