Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

Propose a transaction creation link#8

Merged
rzadp merged 14 commits intomainfrom
rzadp/propose-tx
Aug 18, 2023
Merged

Propose a transaction creation link#8
rzadp merged 14 commits intomainfrom
rzadp/propose-tx

Conversation

@rzadp
Copy link
Copy Markdown
Contributor

@rzadp rzadp commented Aug 17, 2023

  • When prompted, we respond with a TX creation link - example new example
  • Removed restriction to allowed github team - because the bot doesn't send any transactions to the blockchain or doesn't edit anything - we only respond back with a link.
  • Compared the created proposal remark with 3 different on-chain referenda, and all seems good:

The part with transaction hex creation is quite crazy.
We create a Kusama transaction, and then monkey-patch it to be a Polkadot-Collectives transaction.
PRs to make it more sane are welcome - I spent quite some time on it and this is the best I could come up with. 😅

@rzadp rzadp requested a review from a team as a code owner August 17, 2023 16:57
Comment thread src/referendum-request.ts Outdated
Comment thread src/referendum-request.ts Outdated
Comment thread src/referendum-request.ts Outdated
Comment thread src/referendum-tx.ts
Comment thread src/util.test.ts Outdated
Comment thread src/referendum-tx.ts
Comment thread src/referendum-request.ts
Comment thread src/referendum-request.ts Outdated
Comment thread src/referendum-request.ts Outdated
Comment thread src/referendum-request.ts Outdated
@rzadp
Copy link
Copy Markdown
Contributor Author

rzadp commented Aug 18, 2023

@mordamax @Bullrich I made updates and responded to your reviews.

@rzadp rzadp requested review from Bullrich and mordamax August 18, 2023 11:20
Copy link
Copy Markdown

@mordamax mordamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rzadp rzadp merged commit c19354a into main Aug 18, 2023
@rzadp rzadp deleted the rzadp/propose-tx branch August 18, 2023 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants