This repository was archived by the owner on Jun 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Discuss rules #67
Closed
Closed
Discuss rules #67
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ab9456f
Create rules.md
joao-paulo-parity 7d5ac1c
Update rules.md
joao-paulo-parity 3b56b4d
Remove <!-- -->
joao-paulo-parity 8482294
Update rules.md
joao-paulo-parity 8e7e6c9
Apply suggestions from code review
TriplEight b7ba58e
Apply suggestions from code review
TriplEight 056871b
Apply suggestions from code review
TriplEight e63b255
final requirements and group names
TriplEight d6d5572
review suggestions
TriplEight da1d81b
dvdplm's suggesions
TriplEight File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Substrate | ||
|
|
||
| - 🔒️ed lines are reviewed by 2 team leads, one of them must be in the group {@gavofyork, @shawntabrizi, @rphmeier, @bkchr} and the other in another team, @paritytech/polkadotleads | ||
| - PRs are reviewed by 2 of @paritytech/core-devs | ||
TriplEight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| # Polkadot | ||
|
|
||
| - 🔒️ed lines are reviewed by 2 team leads, one of them must be in the group {@gavofyork, @shawntabrizi, @rphmeier, @bkchr} and the other in another team, @paritytech/polkadotleads | ||
TriplEight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - PRs are reviewed by 2 of @paritytech/core-devs | ||
TriplEight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - The following files are reviewed by 2 team leads, one of them must be in the group {@gavofyork, @shawntabrizi, @rphmeier, @bkchr} and the other in another team, @paritytech/polkadotleads | ||
TriplEight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - `/runtime/{kusama|polkadot}/src/*.rs`, except weight files | ||
|
|
||
| # Cumulus | ||
|
|
||
| - 🔒️ed lines are reviewed by 2 team leads, one of them must be in the group {@joepetrowski, @shawntabrizi, @rphmeier, @bkchr} and the other in another team, @paritytech/polkadotleads | ||
TriplEight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - PRs are reviewed by 2 of @paritytech/core-devs | ||
TriplEight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - The following files are reviewed by 2 team leads, one of them must be in the group {@joepetrowski, @shawntabrizi, @rphmeier, @bkchr} and the other in another team, @paritytech/polkadotleads | ||
TriplEight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - `polkadot-parachains/{statemine|statemint}/src/*.rs`, except weight files | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.