This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update and fix wasm code again, add cli check to .gitlab-ci.yml#917
Merged
Update and fix wasm code again, add cli check to .gitlab-ci.yml#917
Conversation
rphmeier
approved these changes
Mar 20, 2020
tomaka
reviewed
Mar 20, 2020
| await init('./pkg/polkadot_cli_bg.wasm'); | ||
| log('Successfully loaded WASM'); | ||
| log('Fetching chain spec'); | ||
| const chain_spec_response = await fetch("https://raw.githubusercontent.com/paritytech/polkadot/master/service/res/westend.json"); |
Contributor
There was a problem hiding this comment.
As mentioned in the browser-light-client chat: I don't think that can work, as the format of the database and the network message are directly derived from the runtime's code.
Contributor
There was a problem hiding this comment.
It's also ideologically questionable to download the chainspecs from something that Parity owns, as the entire point of the blockchain client is to not rely on a central authority.
Also, if GitHub goes down, the node doesn't work.
Contributor
There was a problem hiding this comment.
The node devs have to be trusted in any case, but I agree that we shouldn't be downloading from GitHub if avoidable. Still, I view in-browser light client as a prototype at the moment, where we can make some allowances as nobody uses it yet :)
tomaka
reviewed
Mar 20, 2020
Co-Authored-By: Pierre Krieger <[email protected]>
gavofyork
added
A0-please_review
HCastano
added a commit
to HCastano/polkadot
that referenced
this pull request
Apr 27, 2021
f95cc7a5 Merge branch 'master' into hc-add-wococo-support a13ee0bc Bump Substrate (paritytech#939) f8680cbf jsonrpsee alpha6 (paritytech#938) 6163bcbf reonnect to failed client in on-demand relay background task (paritytech#936) 14e82bea Do not spawn additional task for on-demand relays (paritytech#933) b1557b88 Relay at least one header for every source chain session (paritytech#923) 9420649c Remove deprecated Runtime Header APIs (paritytech#932) 9627011e Update README.md (paritytech#931) 7b736b9c Truncate output in logs. (paritytech#930) faad06e3 Make sure that relayers have dates in logs. (paritytech#927) 07734535 Update dump-logs script. (paritytech#928) efe215e4 RustFmt 02522249 Fix test 48b41d82 Add support for relaying headers between Rococo and Wococo f16b6b41 Add CLI support for initializing the Wococo<>Rococo bridge 8c6e6443 Add more Wococo boilerplate code c2d56b2e Add pruning to bechmarks & update weights. (paritytech#918) a30c51dc Add properties to Chain Spec (paritytech#917) 28d3ed2f Add Wococo primitives crate d691c73e Fix issue with on-demand headers relay not starting (paritytech#921) 8ee55c1e Fix image publishing. (paritytech#922) f51fb59d Prefix in relay loops logs (paritytech#920) git-subtree-dir: bridges git-subtree-split: f95cc7a57b48948f17d33f5be3ea01c752deba94
HCastano
added a commit
that referenced
this pull request
Apr 29, 2021
801c99f3 Add Wococo<>Rococo Header Relayer (#925) 21f49051 Remove Westend<>Rococo header sync (#940) 06235f16 do not panic if pallet is not yet initialized (#937) a13ee0bc Bump Substrate (#939) f8680cbf jsonrpsee alpha6 (#938) 6163bcbf reonnect to failed client in on-demand relay background task (#936) 14e82bea Do not spawn additional task for on-demand relays (#933) b1557b88 Relay at least one header for every source chain session (#923) 9420649c Remove deprecated Runtime Header APIs (#932) 9627011e Update README.md (#931) 7b736b9c Truncate output in logs. (#930) faad06e3 Make sure that relayers have dates in logs. (#927) 07734535 Update dump-logs script. (#928) c2d56b2e Add pruning to bechmarks & update weights. (#918) a30c51dc Add properties to Chain Spec (#917) d691c73e Fix issue with on-demand headers relay not starting (#921) 8ee55c1e Fix image publishing. (#922) f51fb59d Prefix in relay loops logs (#920) git-subtree-dir: bridges git-subtree-split: 801c99f3de0fa4d0b61e4e065fa30817179368ea
tomusdrw
added a commit
that referenced
this pull request
May 3, 2021
f43c92430 Fix account derivation in CLI (#952) 9ac07e733 Add backbone configuration of cargo-spellcheck (#924) 2761c3fef Message dispatch support multiple instances (#942) 801c99f3d Add Wococo<>Rococo Header Relayer (#925) 21f490514 Remove Westend<>Rococo header sync (#940) 06235f162 do not panic if pallet is not yet initialized (#937) a13ee0bc3 Bump Substrate (#939) f8680cbfc jsonrpsee alpha6 (#938) 6163bcbf4 reonnect to failed client in on-demand relay background task (#936) 14e82bea3 Do not spawn additional task for on-demand relays (#933) b1557b882 Relay at least one header for every source chain session (#923) 9420649c1 Remove deprecated Runtime Header APIs (#932) 9627011e1 Update README.md (#931) 7b736b9cc Truncate output in logs. (#930) faad06e39 Make sure that relayers have dates in logs. (#927) 077345351 Update dump-logs script. (#928) c2d56b2e9 Add pruning to bechmarks & update weights. (#918) a30c51dc9 Add properties to Chain Spec (#917) d691c73e9 Fix issue with on-demand headers relay not starting (#921) 8ee55c1e1 Fix image publishing. (#922) f51fb59d0 Prefix in relay loops logs (#920) git-subtree-dir: bridges git-subtree-split: f43c924301c227d29ec161f6815d9bac458a211d
HCastano
added a commit
that referenced
this pull request
May 4, 2021
b2099c5c Bump Substrate to `b094edaf` (#958) 3f037094 Bump endowment amounts on Rialto and Millau (#957) b21fd07c Bump Substrate WASM builder (#947) 30ccd07c Bump Substrate to `ec180313` (#955) a7422ab1 Upgrade to GitHub-native Dependabot (#945) ed20ef34 Move pallet-bridge-dispatch types to primitives (#948) 2070c4d6 Endow accounts and add `bridgeIds` to chainspec. (#951) f43c9243 Fix account derivation in CLI (#952) 9ac07e73 Add backbone configuration of cargo-spellcheck (#924) 2761c3fe Message dispatch support multiple instances (#942) 801c99f3 Add Wococo<>Rococo Header Relayer (#925) 21f49051 Remove Westend<>Rococo header sync (#940) 06235f16 do not panic if pallet is not yet initialized (#937) a13ee0bc Bump Substrate (#939) f8680cbf jsonrpsee alpha6 (#938) 6163bcbf reonnect to failed client in on-demand relay background task (#936) 14e82bea Do not spawn additional task for on-demand relays (#933) b1557b88 Relay at least one header for every source chain session (#923) 9420649c Remove deprecated Runtime Header APIs (#932) 9627011e Update README.md (#931) 7b736b9c Truncate output in logs. (#930) faad06e3 Make sure that relayers have dates in logs. (#927) 07734535 Update dump-logs script. (#928) c2d56b2e Add pruning to bechmarks & update weights. (#918) a30c51dc Add properties to Chain Spec (#917) d691c73e Fix issue with on-demand headers relay not starting (#921) 8ee55c1e Fix image publishing. (#922) f51fb59d Prefix in relay loops logs (#920) git-subtree-dir: bridges git-subtree-split: b2099c5c0baf569e2ec7228507b6e4f3972143cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.