Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion: restructure macro related exports#7626

Merged
paritytech-processbot[bot] merged 13 commits intomasterfrom
jg/restructure-macro-related-exports
Aug 23, 2023
Merged

Companion: restructure macro related exports#7626
paritytech-processbot[bot] merged 13 commits intomasterfrom
jg/restructure-macro-related-exports

Conversation

@juangirini
Copy link
Copy Markdown
Contributor

@juangirini juangirini commented Aug 15, 2023 •
edited
Loading

Restructure frame_benchmarking and frame_support macro related exports

Companion for paritytech/substrate#14745

@juangirini juangirini added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Aug 15, 2023
@paritytech-ci paritytech-ci requested review from a team August 15, 2023 15:57
@juangirini juangirini mentioned this pull request Aug 15, 2023
Merged
@ggwpez ggwpez added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. and removed A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. labels Aug 15, 2023
ggwpez
ggwpez approved these changes Aug 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this ahead of the upstream Substrate MR.

@juangirini juangirini changed the title Companion: restructure macro related exports Companion: restructure frame_support macro related exports Aug 16, 2023
@juangirini
Copy link
Copy Markdown
Contributor Author

juangirini commented Aug 16, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 16, 2023

Rebased

@juangirini
Copy link
Copy Markdown
Contributor Author

juangirini commented Aug 16, 2023

bot fmt

@command-bot
Copy link
Copy Markdown

command-bot bot commented Aug 16, 2023 •
edited
Loading

@juangirini https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3402390 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 38-19dbffa1-5afa-4796-b06b-a25ec23f58ba to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link
Copy Markdown

command-bot bot commented Aug 16, 2023

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3402390 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3402390/artifacts/download.

@paritytech-ci paritytech-ci requested a review from a team August 21, 2023 08:56
@juangirini
Copy link
Copy Markdown
Contributor Author

juangirini commented Aug 21, 2023

bot rebaes

@command-bot
Copy link
Copy Markdown

command-bot bot commented Aug 21, 2023

@juangirini Unknown command "rebaes"; Available ones are bench-all, bench-bm, bench-overhead, bench, fmt, merge, rebase, sample, try-runtime, update-ui. Refer to help docs and/or source code.

@juangirini
Copy link
Copy Markdown
Contributor Author

juangirini commented Aug 21, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 21, 2023

Rebased

@juangirini juangirini changed the title Companion: restructure frame_support macro related exports Companion: restructure macro related exports Aug 22, 2023
@juangirini juangirini mentioned this pull request Aug 22, 2023
Merged
@juangirini
Copy link
Copy Markdown
Contributor Author

juangirini commented Aug 22, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 22, 2023

Rebased

@juangirini
Copy link
Copy Markdown
Contributor Author

juangirini commented Aug 23, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 7f0eb5f into master Aug 23, 2023
@paritytech-processbot paritytech-processbot bot deleted the jg/restructure-macro-related-exports branch August 23, 2023 11:39
vstakhov pushed a commit that referenced this pull request Aug 24, 2023
@juangirini @vstakhov
Companion: restructure macro related exports (#7626)
44f1ce6 
* move RuntimeDebug out of frame_support

* move RuntimeDebug out of frame_support

* fix xcm export

* ".git/.scripts/commands/fmt/fmt.sh"

* fix xcm intefration tests

* fix cargo lock for xcm intefration tests

* wip

* restructure benchmarking macro related exports

* update cargo lock

---------

Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andresilva andresilva Awaiting requested review from andresilva

@eskimor eskimor Awaiting requested review from eskimor

@athei athei Awaiting requested review from athei

@stefan-sopic stefan-sopic Awaiting requested review from stefan-sopic

@kianenigma kianenigma Awaiting requested review from kianenigma

@rphmeier rphmeier Awaiting requested review from rphmeier

@sandreim sandreim Awaiting requested review from sandreim

5 more reviewers

@kpp kpp kpp approved these changes

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

@liamaharon liamaharon liamaharon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@juangirini @kpp @ordian @bkchr @ggwpez @liamaharon