This repository was archived by the owner on Nov 15, 2023. It is now read-only.
chain-spec: support for json config/patch (and GenesisBuilder API)#7508
Open
michalkucharczyk wants to merge 20 commits intomasterfrom
Open
chain-spec: support for json config/patch (and GenesisBuilder API)#7508michalkucharczyk wants to merge 20 commits intomasterfrom
chain-spec: support for json config/patch (and GenesisBuilder API)#7508michalkucharczyk wants to merge 20 commits intomasterfrom
Conversation
New feature fast-runtime-10m was added. This adds new rococo-runtime blob with hard-coded epochDuration. This prevents from manipulating the state to change the runtime constants. This commit also allows to remove `RococoGenesisExt` hack.
In this commit: - all references to `RuntimeGenesisConfig` are removed, - `RococoGenesisExt` is removed. It was the hack to allow overwriting `EpochDurationInBlocks` (1m/10m/60m rococo runtimes are now available), - all `(kusama|polkadot|versi|rococo|wococo)_(staging|dev)_genesis_config` functions now return the JSON patch for default runtime `GenesisConfig`, - ChainSpecBuilder is used, `from_gensis` is removed,
…ort-for-genesis-builder-api
Explicitly building fast-runtime version of rococo runtime is no longer done. Environment variables which control the time::EpochDurationInBlocks value were added: - ROCOCO_FAST_RUNTIME - enables the fast runtime version of runtime with default value of EpochDurationInBlocks set to 10. Value of env does not matter. - ROCOCO_EPOCH_DURATION - enables the fast runtime version with provided value of EpochDurationInBlocks (epoch duration will be set to the value of env). Examples: - to build runtime for `versi_staging_testnet_config which had EpochDurationInBlocks set to 100: ``` ROCOCO_EPOCH_DURATION=100 cargo build -p rococo ``` - to build runtime for `versi_staging_testnet_config which had EpochDurationInBlocks set to 100: ``` ROCOCO_EPOCH_DURATION=100 cargo build -p rococo-runtime ``` - to build runtime for `wococo_development` ``` ROCOCO_EPOCH_DURATION=10 cargo build -p rococo-runtime or ROCOCO_FAST_RUNTIME=1 cargo build -p rococo-runtime ```
Contributor
Author
|
bot rebase |
…ort-for-genesis-builder-api
|
Rebased |
…ort-for-genesis-builder-api
michalkucharczyk
added
A3-in_progress
Contributor
Author
|
bot rebase |
…ort-for-genesis-builder-api
|
Rebased |
michalkucharczyk
removed
the
A3-in_progress
Contributor
Author
|
bot rebase |
…ort-for-genesis-builder-api
|
Rebased |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Contributor
Author
|
@paritytech/devrel , @the-right-joyce I wanted to give you a heads-up about some changes that have just been made in this PR. I've modified the default You can find additional details in the PR description. This change could affect tutorials (and docs maybe?) that rely on timing within these runtimes. Therefore, I request you to please review and update them accordingly, and include information on how to adjust timings based on these changes. Thank you for your attention. |
This was referenced Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a step towards adding support of RuntimeGenesisConfig into the wasm runtime:
In this PR:
all references to
RuntimeGenesisConfiginnode/serviceare removed,RococoGenesisExtis removed. It was the hack to allow overwritingEpochDurationInBlocks. Removal ofRococGenesisExtprevents from manipulating the state to change the runtime constants, what allows to keep metadata const.all
(kusama|polkadot|versi|rococo|wococo)_(staging|dev)_genesis_configfunctions now return the JSON patch for default runtimeGenesisConfig,ChainSpecBuilderis used,ChainSpec::from_genesisis removed,rococo-runtimechanges:rococo-runtimeis no longer done.time::EpochDurationInBlocksvalue were added:ROCOCO_FAST_RUNTIME- enables the fast runtime version of runtime with default value of EpochDurationInBlocks set to 10. Value ofenvdoes not matter.ROCOCO_EPOCH_DURATION- enables the fast runtime version with provided value of EpochDurationInBlocks (epoch duration will be set to the value of env).rococo-runtimebuilding examples:versi_staging_testnetwhich had EpochDurationInBlocks set to 100:wococo_developmentversi-stagingchain spec:wococo-devchain spec:Companion for: paritytech/substrate#14562
cumulus companion: paritytech/cumulus#2936
Step towards: paritytech/polkadot-sdk#25