This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Patch CI for split out worker binaries#7360
Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom Jun 14, 2023
Merged
Patch CI for split out worker binaries#7360paritytech-processbot[bot] merged 1 commit intomasterfrom
paritytech-processbot[bot] merged 1 commit intomasterfrom
Conversation
s0me0ne-unkn0wn
added
A0-please_review
mateo-moon
approved these changes
Jun 14, 2023
alvicsam
approved these changes
Jun 14, 2023
Contributor
Author
|
bot merge |
paritytech-processbot
bot
deleted the
s0me0ne/pvf-split-out-worker-binaries-ci
branch
s0me0ne-unkn0wn
added a commit
that referenced
this pull request
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks #7337
We're experimenting with splitting out the PVF workers to separate binaries which are supposed to be distributed along with the main
polkadotbinary in the future. This PR aims to incorporate the binaries in question into the docker images pushed to dockerhub to enable downstream pipelines, like zombienet tests, to run in that configuration, still preserving backward compatibility for builds that do not require multiple binaries.I didn't test these changes. They are obvious, and I checked the docs twice, but I'm lacking the infrastructure required to perform testing on my machine.