This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Move vstaging to production#7341
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Jun 12, 2023
Merged
Conversation
WIP: test-runtime still needs to be fixed.
6 tasks
|
The CI pipeline was cancelled due to failure one of the required jobs. |
eskimor
changed the title
eskimor
added
A0-please_review
s0me0ne-unkn0wn
suggested changes
Jun 8, 2023
Contributor
s0me0ne-unkn0wn
left a comment
s0me0ne-unkn0wn
left a comment
There was a problem hiding this comment.
LGTM, except for a minor method existence check issue
s0me0ne-unkn0wn
approved these changes
Jun 8, 2023
tdimitrov
reviewed
Jun 8, 2023
|
|
||
| /// Returns a merkle proof of a validator session key. | ||
| #[api_version(5)] | ||
| /// NOTE: This function is only available since parachain host version 5. |
Contributor
There was a problem hiding this comment.
It's not ideal loosing version information when bumping base but it is what it is :(
tdimitrov
approved these changes
Jun 8, 2023
ordian
approved these changes
Jun 8, 2023
rphmeier
approved these changes
Jun 9, 2023
Contributor
rphmeier
left a comment
rphmeier
left a comment
There was a problem hiding this comment.
excited to see this land!
Member
Author
|
bot merge |
paritytech-processbot
bot
deleted the
rk-enable-past-session-slashing-production
branch
paritytech-processbot bot
pushed a commit
to paritytech/cumulus
that referenced
this pull request
Jun 12, 2023
* Companion to enabling past session slashing on production.
* update lockfile for {"substrate", "polkadot"}
---------
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: parity-processbot <>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 13, 2023
* Companion to enabling past session slashing on production.
* update lockfile for {"substrate", "polkadot"}
---------
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: parity-processbot <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which enables past-session slashing on Polkadot and Kusama.
@the-right-joyce
Blocked by: paritytech/cumulus#2708
cumulus companion: paritytech/cumulus#2726