This repository was archived by the owner on Nov 15, 2023. It is now read-only.
para scheduler: fix division#7339
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Jun 11, 2023
Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
liamaharon
approved these changes
Jun 7, 2023
shawntabrizi
approved these changes
Jun 7, 2023
gilescope
approved these changes
Jun 7, 2023
Member
Author
|
I am actually going to close this since this cant be the root cause. The group rotating frequency is set to 10 in the previous block and should never be zero by invariant. |
Member
|
Still seems like a pretty safe thing to add? |
Member
Author
|
Yea right, it should not do any harm. The actual fix is in #7340 |
liamaharon
added
A2-insubstantial
liamaharon
approved these changes
Jun 7, 2023
liamaharon
added
A0-please_review
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
kianenigma
approved these changes
Jun 8, 2023
shawntabrizi
approved these changes
Jun 11, 2023
Contributor
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RIP Westend
There are a lot more cases where this number is used in arithmetic, so I assume that it should not be zero to beginn with.
So maybe one of the migrations caused it.