Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add tests for PayOverXcm#7319

Merged
paritytech-processbot[bot] merged 15 commits intomasterfrom
cisco-pay-over-xcm-tests
Aug 19, 2023
Merged

Add tests for PayOverXcm#7319
paritytech-processbot[bot] merged 15 commits intomasterfrom
cisco-pay-over-xcm-tests

Conversation

@franciscoaguirre
Copy link
Copy Markdown
Contributor

@franciscoaguirre franciscoaguirre commented May 31, 2023 •
edited
Loading

Adding tests for the new xcm-builder item, PayOverXcm, introduced in #6900.

TODO

  • Add all type parameters required to call pay on the test
  • Add test for native asset on destination chain
  • Add test for derivative asset on destination chain
  • Add test for salary pallet with PayOverXcm

@franciscoaguirre franciscoaguirre added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T6-XCM This PR/Issue is related to XCM. labels May 31, 2023
@franciscoaguirre
Copy link
Copy Markdown
Contributor Author

franciscoaguirre commented Jun 5, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Jun 5, 2023

Error: Command 'Command { std: cd "/storage/repositories/polkadot" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

@franciscoaguirre franciscoaguirre force-pushed the cisco-pay-over-xcm-tests branch 2 times, most recently from 826f63c to 8867d33 Compare June 6, 2023 20:53
franciscoaguirre
franciscoaguirre commented Jun 6, 2023
View reviewed changes
@franciscoaguirre franciscoaguirre force-pushed the cisco-pay-over-xcm-tests branch from 8867d33 to b0dc210 Compare June 6, 2023 20:55
vstam1
vstam1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for as far as I understand the salary pallet.

Maybe add test for PayAccountId32OnChainOverXcm as well?

vstam1
vstam1 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscoaguirre franciscoaguirre marked this pull request as ready for review July 26, 2023 14:30
@franciscoaguirre franciscoaguirre added A0-please_review Pull request needs code review. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. and removed A3-in_progress Pull request is in progress. No review needed at this stage. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 26, 2023
@franciscoaguirre
Copy link
Copy Markdown
Contributor Author

franciscoaguirre commented Jul 26, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Jul 26, 2023

Branch is already up-to-date

@franciscoaguirre
Copy link
Copy Markdown
Contributor Author

franciscoaguirre commented Jul 26, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Jul 26, 2023

Branch is already up-to-date

liamaharon
liamaharon reviewed Jul 27, 2023
View reviewed changes
@franciscoaguirre franciscoaguirre mentioned this pull request Jul 31, 2023
Open
KiChjang
KiChjang reviewed Aug 3, 2023
View reviewed changes
KiChjang
KiChjang reviewed Aug 3, 2023
View reviewed changes
@franciscoaguirre franciscoaguirre changed the title Add tests for PayOverXcm Add tests for PayOverXcm m Aug 8, 2023
@franciscoaguirre franciscoaguirre changed the title Add tests for PayOverXcm m Add tests for PayOverXcm Aug 8, 2023
@franciscoaguirre
Copy link
Copy Markdown
Contributor Author

franciscoaguirre commented Aug 17, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 17, 2023

Rebased

KiChjang
KiChjang reviewed Aug 18, 2023
View reviewed changes
@franciscoaguirre
Copy link
Copy Markdown
Contributor Author

franciscoaguirre commented Aug 19, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 47e58ac into master Aug 19, 2023
@paritytech-processbot paritytech-processbot bot deleted the cisco-pay-over-xcm-tests branch August 19, 2023 13:39
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@liamaharon liamaharon liamaharon left review comments

@KiChjang KiChjang KiChjang approved these changes

@vstam1 vstam1 vstam1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T6-XCM This PR/Issue is related to XCM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@franciscoaguirre @KiChjang @vstam1 @liamaharon