Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Serialize/Deserialize trait implemented in no-std for numerous types#7312

Merged
paritytech-processbot[bot] merged 9 commits intomasterfrom
mku-serialize-for-para-id
Jun 1, 2023
Merged

Serialize/Deserialize trait implemented in no-std for numerous types#7312
paritytech-processbot[bot] merged 9 commits intomasterfrom
mku-serialize-for-para-id

Conversation

@michalkucharczyk
Copy link
Copy Markdown
Contributor

@michalkucharczyk michalkucharczyk commented May 30, 2023 •
edited
Loading

serde feature was NOT introduced into updated crates.

Required for paritytech/polkadot-sdk#25

Companion for: paritytech/substrate#14261
cumulus companion: paritytech/cumulus#2660

@michalkucharczyk michalkucharczyk requested a review from a team May 30, 2023 22:10
@michalkucharczyk michalkucharczyk added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 30, 2023
@michalkucharczyk michalkucharczyk changed the title ParaId: Serialize/Deserialize trait implemented in no-std Serialize/Deserialize trait implemented in no-std for numerous types May 31, 2023
@michalkucharczyk michalkucharczyk mentioned this pull request May 31, 2023
Merged
melekes
melekes approved these changes May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Jun 1, 2023

Merge cancelled due to error. Error: Head SHA changed from a4949f8 to c93fb62

@michalkucharczyk
Copy link
Copy Markdown
Contributor Author

michalkucharczyk commented Jun 1, 2023

bot format

@command-bot
Copy link
Copy Markdown

command-bot bot commented Jun 1, 2023

@michalkucharczyk Unknown command "format"; Available ones are bench-all, bench-vm, bench, fmt, merge, rebase, sample, try-runtime. Refer to help docs and/or source code.

@michalkucharczyk
Copy link
Copy Markdown
Contributor Author

michalkucharczyk commented Jun 1, 2023

bot fmt

@command-bot
Copy link
Copy Markdown

command-bot bot commented Jun 1, 2023 •
edited
Loading

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2930107 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 52-fca60f93-58b3-4a39-a890-e98eba019ee2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link
Copy Markdown

command-bot bot commented Jun 1, 2023

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2930107 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2930107/artifacts/download.

@michalkucharczyk
Copy link
Copy Markdown
Contributor Author

michalkucharczyk commented Jun 1, 2023

bot merge

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Jun 1, 2023

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 48982ae into master Jun 1, 2023
@paritytech-processbot paritytech-processbot bot deleted the mku-serialize-for-para-id branch June 1, 2023 16:17
@lexnv lexnv mentioned this pull request Jun 1, 2023
Merged
@fgamundi fgamundi mentioned this pull request Jan 24, 2024
Merged
@fgamundi fgamundi mentioned this pull request Jan 25, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@melekes melekes melekes approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalkucharczyk @melekes @bkchr