Add OpenGov to Rococo and Westend runtimes by al3mart · Pull Request #7272 · paritytech/polkadot

al3mart · 2023-05-23T11:12:00Z

As per this comment, the changes in this MR include the following pallets into [x] Rococo and [x] Westend runtimes:

pallet_conviction_voting
pallet_referenda
pallet_ranked_collective
pallet_custom_origins
pallet_whitelist

And only for westend-runtime:

pallet_treasury

Following Kusama runtime config as a baseline.

Benchmarking of the following pallets done for Rococo and Westend:

pallet_conviction_voting
pallet_referenda
pallet_ranked_collective
pallet_whitelist

And only for Westend:

pallet_treasury
Remove Gov1 from Rococo as in Introduce OpenGov into Polkadot #6701

al3mart · 2023-05-23T11:31:54Z

Seems that I went to fast with the changes, will convert to draft for the moment until all commits are in place.

al3mart · 2023-05-23T12:45:33Z

Might as well transform this MR into introducing OpenGov in Rococo as there as been some interest.

al3mart · 2023-07-06T15:59:11Z

I might do a few more commits removing Gov1 from Rococo, but opening for reviews to see if anything needs addressing with the inclusion of the pallets mentioned in the description.

runtime/westend/constants/src/lib.rs

mordamax · 2023-07-06T21:48:24Z

runtime/rococo/src/weights/pallet_whitelist.rs

+// --execution=wasm
+// --wasm-execution=compiled
+// --header=./file_header.txt
+// --output=./runtime/kusama/src/weights/


was it just copied from kusama? is it ok or ideally it should be generated with command bot?

👍 I'd say that generating its own weights would be the way to go. I'll address this

its one way to do this. to copy from other network or even substrate, and after run the weights via PR bot

Benchmarks done!

did you rerun them? this file would be rewritten

runtime/rococo/src/governance/fellowship.rs

muharem · 2023-07-07T14:00:50Z

runtime/rococo/src/governance/fellowship.rs

+					max_deciding: 10,
+					decision_deposit: 100 * QUID,
+					prepare_period: 30 * MINUTES,
+					decision_period: 7 * DAYS,


not sure if we want the exact same configs, or we want to relax all constraints, to have shorter periods, approve and support curves, etc

runtime/rococo/src/governance/mod.rs

muharem · 2023-07-07T14:07:01Z

runtime/rococo/src/weights/pallet_whitelist.rs

+// --execution=wasm
+// --wasm-execution=compiled
+// --header=./file_header.txt
+// --output=./runtime/kusama/src/weights/


its one way to do this. to copy from other network or even substrate, and after run the weights via PR bot

Co-authored-by: Muharem Ismailov <[email protected]>

al3mart · 2023-08-05T00:23:28Z

@mordamax @muharem @joepetrowski I think we can follow up with the review now :)
Gov1 related stuff has been removed from rococo's runtime.

It might be interesting to get this merge before the migration to the monorepo :P

runtime/rococo/src/governance/fellowship.rs

muharem · 2023-08-10T13:22:20Z

runtime/rococo/src/weights/pallet_whitelist.rs

+// --execution=wasm
+// --wasm-execution=compiled
+// --header=./file_header.txt
+// --output=./runtime/kusama/src/weights/


did you rerun them? this file would be rewritten

runtime/westend/src/governance/fellowship.rs

muharem · 2023-08-10T13:28:17Z

almost there (:
the main request is to follow Polkadot setup for Westend
push - "Re-request review" when comments addressed

al3mart · 2023-08-16T22:34:48Z

bot bench $ runtime rococo pallet_whitelist

command-bot · 2023-08-16T22:34:51Z

@al3mart Positional arguments are not supported anymore. I guess you meant bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist, but I could be wrong.
Read docs to find out how to run your command.

al3mart · 2023-08-16T22:35:32Z

bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist

command-bot · 2023-08-16T22:35:36Z

@al3mart https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3404547 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 42-bf78976e-d11c-404e-8f75-28587a10bd6d to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-08-16T22:38:28Z

@al3mart Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3404547 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3404547/artifacts/download.

al3mart · 2023-08-25T03:01:07Z

bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist

command-bot · 2023-08-25T03:01:11Z

@al3mart https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3437453 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-8307bfdb-702f-46a0-8ce5-cf393f2f861a to cancel this command or bot cancel to cancel all commands in this pull request.

…e=rococo --target_dir=polkadot --pallet=pallet_whitelist

command-bot · 2023-08-25T03:46:59Z

@al3mart Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3437453 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3437453/artifacts/download.

al3mart · 2023-08-25T03:58:21Z

Ready for another review round

Rococo bounties SpendOrigin to root

6ed0f84

al3mart added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 23, 2023

al3mart requested a review from riusricardo May 23, 2023 11:12

al3mart added the A0-please_review Pull request needs code review. label May 23, 2023

al3mart changed the title ~~Set bounties SpendOrigin in Rococo to EnsureRoot~~ Set treasury SpendOrigin in Rococo to EnsureRoot May 23, 2023

al3mart marked this pull request as draft May 23, 2023 11:31

al3mart changed the title ~~Set treasury SpendOrigin in Rococo to EnsureRoot~~ Allow Root as SpendOrigin in Rococo May 23, 2023

al3mart removed the A0-please_review Pull request needs code review. label May 24, 2023

al3mart added 2 commits June 26, 2023 10:11

Merge branch 'master' into al3mart/rococo-spendorigin

6500cf8

opengov in Rococo

0bf252d

al3mart changed the title ~~Allow Root as SpendOrigin in Rococo~~ Add OpenGov to Rococo and Westend runtimes Jul 5, 2023

al3mart added 5 commits July 6, 2023 12:44

opengov in Westend

86e050e

sp-keystore wout serde feature

34be311

QueuePausedQuery & bump recursion limit

74e2d4f

merge master

450e6ee

trasury in westend chainspec

8a21492

al3mart marked this pull request as ready for review July 6, 2023 15:57

al3mart requested review from joepetrowski and mordamax July 6, 2023 15:58

al3mart requested a review from muharem July 6, 2023 16:00

joepetrowski reviewed Jul 6, 2023

View reviewed changes

runtime/westend/constants/src/lib.rs Outdated Show resolved Hide resolved

mordamax reviewed Jul 6, 2023

View reviewed changes

muharem reviewed Jul 7, 2023

View reviewed changes

al3mart and others added 2 commits July 7, 2023 21:45

removing QUID

0d51017

Update runtime/rococo/src/governance/mod.rs

734b309

Co-authored-by: Muharem Ismailov <[email protected]>

al3mart added 7 commits August 3, 2023 23:08

remove gov1 from rococo xcm_config

4ad2c13

remove gov1 rococo deps

158bd40

remove unused weights

46f6e54

rococo chain_spec

094107a

cargo update

7083b8e

merge conflicts

cf7d0d8

cargo update

47c3847

al3mart marked this pull request as ready for review August 5, 2023 00:23

al3mart removed the request for review from riusricardo August 5, 2023 00:25

muharem self-requested a review August 10, 2023 12:12

muharem reviewed Aug 10, 2023

View reviewed changes

al3mart added 3 commits August 25, 2023 02:02

merge master

8477d48

take CheckedReduceBy from sp_runtime

9e2dbe4

westend to follow polkadot

cc5cccc

".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtim…

9692495

…e=rococo --target_dir=polkadot --pallet=pallet_whitelist

al3mart requested review from joepetrowski, mordamax and muharem August 25, 2023 03:58

al3mart mentioned this pull request Aug 25, 2023

OpenGov in Westend and Rococo paritytech/polkadot-sdk#1177

Merged

Conversation

al3mart commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

al3mart commented May 23, 2023

Uh oh!

al3mart commented May 23, 2023

Uh oh!

al3mart commented Jul 6, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

al3mart commented Aug 5, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

muharem commented Aug 10, 2023

Uh oh!

al3mart commented Aug 16, 2023

Uh oh!

command-bot bot commented Aug 16, 2023

Uh oh!

al3mart commented Aug 16, 2023

Uh oh!

command-bot bot commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Aug 16, 2023

Uh oh!

al3mart commented Aug 25, 2023

Uh oh!

command-bot bot commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Aug 25, 2023

Uh oh!

al3mart commented Aug 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

al3mart commented May 23, 2023 •

edited

Loading

command-bot bot commented Aug 16, 2023 •

edited

Loading

command-bot bot commented Aug 25, 2023 •

edited

Loading