paras: dismiss `pvf_checking_enabled` configuration by slumber · Pull Request #7138 · paritytech/polkadot

slumber · 2023-04-26T14:41:58Z

Part of #3211

Node side doesn't require any changes. Prechecking subsystem is conditionally disabled if the node is not authority, disregarding the runtime configuration. So I suggest we leave it as is.

Removing pvf_checking_enabled from host configuration requires storage migration. This can be done in the same PR or in a follow-up, depending on how quickly this gets merged. For now it's simply ignored.

runtime/parachains/src/scheduler/tests.rs

slumber · 2023-05-02T20:34:15Z

bot bench $ runtime polkadot runtime_parachains::paras

command-bot · 2023-05-02T20:34:20Z

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766578 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 19-56cbc500-0ab1-4a3b-bba3-66998546da8a to cancel this command or bot cancel to cancel all commands in this pull request.

…HEAD

…chains::paras

command-bot · 2023-05-02T21:54:33Z

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766578 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766578/artifacts/download.

slumber · 2023-05-02T21:56:09Z

bot bench $ runtime kusama runtime_parachains::paras

command-bot · 2023-05-02T21:56:13Z

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766810 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 20-4e0dc300-2035-4c60-9551-7128217ff3ab to cancel this command or bot cancel to cancel all commands in this pull request.

…ains::paras

command-bot · 2023-05-02T23:16:38Z

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766810 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2766810/artifacts/download.

slumber · 2023-05-03T05:43:12Z

bot bench $ runtime rococo runtime_parachains::paras

command-bot · 2023-05-03T05:43:16Z

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2767605 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-604e96d4-785c-4c8a-b443-ef8eca250e52 to cancel this command or bot cancel to cancel all commands in this pull request.

…ains::paras

command-bot · 2023-05-03T07:03:43Z

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2767605 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2767605/artifacts/download.

slumber · 2023-05-03T09:39:15Z

bot bench $ runtime westend runtime_parachains::paras

command-bot · 2023-05-03T09:39:21Z

@slumber https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2769086 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 23-265217b2-3935-4cde-a49c-64f4ac9e936f to cancel this command or bot cancel to cancel all commands in this pull request.

…hains::paras

command-bot · 2023-05-03T10:59:49Z

@slumber Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2769086 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2769086/artifacts/download.

mrcnski

Not super familiar with the runtime-side so I read this for education. Maybe ignore my approval but I think it looks good.

runtime/parachains/src/paras/tests.rs

node/test/service/src/lib.rs

runtime/kusama/src/weights/runtime_parachains_paras.rs

eskimor · 2023-05-05T05:40:40Z

Nice! Great work, only two small remarks. The weight explosion is interesting, do you have any explanation?

slumber · 2023-05-07T16:13:49Z

bot merge

paritytech-processbot · 2023-05-07T16:13:57Z

Error: Statuses failed for 8bc1b33

…checking-cfg

slumber · 2023-05-08T18:07:42Z

bot merge

paritytech-processbot · 2023-05-08T18:07:50Z

Waiting for commit status.

paras: unconditionally precheck pvfs

cabf674

slumber requested review from eskimor, ordian and pepyakin April 26, 2023 14:41

ordian added the T1-runtime This PR/Issue is related to the topic “runtime”. label Apr 26, 2023

ordian approved these changes Apr 26, 2023

View reviewed changes

slumber commented Apr 26, 2023

View reviewed changes

runtime/parachains/src/scheduler/tests.rs Show resolved Hide resolved

slumber mentioned this pull request Apr 26, 2023

Tracking issue: Pre-checking for PVF Compilation time #3211

Closed

24 tasks

slumber added 4 commits April 26, 2023 22:50

Update integration tests

3e16133

paras_registrar tests

44c6326

runtime benchmark tests

2d2fbb0

fix bench

a50ca39

slumber force-pushed the slumber-dismiss-prechecking-cfg branch from 8ea6667 to a50ca39 Compare April 26, 2023 23:18

bypass prechecking in test node

09927f9

slumber force-pushed the slumber-dismiss-prechecking-cfg branch from aa599df to 09927f9 Compare April 27, 2023 09:04

adjust bench

44c414e

slumber mentioned this pull request May 2, 2023

paras: adjust weights for root dispatchables #6347

Closed

command-bot added 2 commits May 2, 2023 20:34

Merge branch 'master' of https://github.com/paritytech/polkadot into …

f4599c2

…HEAD

".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_para…

caaac2f

…chains::paras

".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parach…

4b23f8a

…ains::paras

".git/.scripts/commands/bench/bench.sh" runtime rococo runtime_parach…

f22e03e

…ains::paras

".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parac…

26277a6

…hains::paras

mrcnski approved these changes May 3, 2023

View reviewed changes

runtime/parachains/src/paras/tests.rs Outdated Show resolved Hide resolved

use test helper

8bc1b33

eskimor reviewed May 5, 2023

View reviewed changes

node/test/service/src/lib.rs Show resolved Hide resolved

runtime/kusama/src/weights/runtime_parachains_paras.rs Show resolved Hide resolved

eskimor approved these changes May 5, 2023

View reviewed changes

slumber added 3 commits May 7, 2023 23:08

Merge remote-tracking branch 'origin/master' into slumber-dismiss-pre…

6d4cdd7

…checking-cfg

fix new test

7336612

Merge remote-tracking branch 'origin/master' into slumber-dismiss-pre…

cdfd50a

…checking-cfg

paritytech-processbot bot merged commit 64a4f32 into master May 8, 2023

paritytech-processbot bot deleted the slumber-dismiss-prechecking-cfg branch May 8, 2023 18:58

github-actions bot mentioned this pull request Jun 15, 2023

Update substrate/polkadot/cumulus from v0.9.40 to v0.9.43 moonbeam-foundation/moonbeam#2354

Closed

slumber mentioned this pull request Jun 19, 2023

configuration: drop pvf_checking_enabled parameter #7396

Merged

kiltbot mentioned this pull request Jun 21, 2023

1️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.42 to 0.9.43 KILTprotocol/kilt-node#531

Closed

Conversation

slumber commented Apr 26, 2023

Uh oh!

Uh oh!

slumber commented May 2, 2023

Uh oh!

command-bot bot commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented May 2, 2023

Uh oh!

slumber commented May 2, 2023

Uh oh!

command-bot bot commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented May 2, 2023

Uh oh!

slumber commented May 3, 2023

Uh oh!

command-bot bot commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented May 3, 2023

Uh oh!

slumber commented May 3, 2023

Uh oh!

command-bot bot commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented May 3, 2023

Uh oh!

mrcnski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eskimor commented May 5, 2023

Uh oh!

slumber commented May 7, 2023

Uh oh!

paritytech-processbot bot commented May 7, 2023

Uh oh!

slumber commented May 8, 2023

Uh oh!

paritytech-processbot bot commented May 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

command-bot bot commented May 2, 2023 •

edited

Loading

command-bot bot commented May 2, 2023 •

edited

Loading

command-bot bot commented May 3, 2023 •

edited

Loading

command-bot bot commented May 3, 2023 •

edited

Loading