Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

companion for #13384#6987

Merged
bkchr merged 15 commits intomasterfrom
na-companion-13384
May 4, 2023
Merged

companion for #13384#6987
bkchr merged 15 commits intomasterfrom
na-companion-13384

Conversation

@niklasad1
Copy link
Copy Markdown
Contributor

@niklasad1 niklasad1 commented Mar 31, 2023 •
edited
Loading

cumulus companion: paritytech/cumulus#2417

@niklasad1 niklasad1 mentioned this pull request Mar 31, 2023
Merged
@niklasad1 niklasad1 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels Mar 31, 2023
@niklasad1
Copy link
Copy Markdown
Contributor Author

niklasad1 commented Apr 12, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 12, 2023

Rebased

@niklasad1
Copy link
Copy Markdown
Contributor Author

niklasad1 commented Apr 26, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 26, 2023

Rebased

@niklasad1
Copy link
Copy Markdown
Contributor Author

niklasad1 commented May 3, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented May 3, 2023

Rebased

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented May 3, 2023

Waiting for commit status.

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented May 3, 2023

Merge cancelled due to error. Error: Statuses failed for b6cdf70

@niklasad1 niklasad1 requested a review from a team as a code owner May 3, 2023 15:52
@paritytech-ci paritytech-ci requested a review from a team May 3, 2023 15:53
@paritytech-ci paritytech-ci requested a review from a team May 4, 2023 06:33
@niklasad1 niklasad1 requested a review from chevdor as a code owner May 4, 2023 07:48
@bkchr
Copy link
Copy Markdown
Member

bkchr commented May 4, 2023

@niklasad1 the solution can not just be to let the node upgrade test fail...

People will be confused until there is a release with the new CLI args... Zombienet should be able to handle this, but until this is done the test should be disabled and an issue opened to bring back the test when the stuff is fixed.

@niklasad1 niklasad1 mentioned this pull request May 4, 2023
Closed
@bkchr bkchr merged commit 9b48a89 into master May 4, 2023
@bkchr bkchr deleted the na-companion-13384 branch May 4, 2023 09:48
@pepoviola pepoviola mentioned this pull request May 5, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chevdor chevdor Awaiting requested review from chevdor

@EgorPopelyaev EgorPopelyaev Awaiting requested review from EgorPopelyaev

@coderobe coderobe Awaiting requested review from coderobe

@lovelaced lovelaced Awaiting requested review from lovelaced

@TriplEight TriplEight Awaiting requested review from TriplEight

3 more reviewers

@koute koute koute approved these changes

@bkchr bkchr bkchr approved these changes

@sergejparity sergejparity sergejparity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@niklasad1 @bkchr @koute @sergejparity @pepoviola