Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

XCM ExportMessage benchmark support#6923

Merged
acatangiu merged 3 commits intoparitytech:masterfrom
acatangiu:xcm-exportmessage-benchmark
Mar 23, 2023
Merged

XCM ExportMessage benchmark support#6923
acatangiu merged 3 commits intoparitytech:masterfrom
acatangiu:xcm-exportmessage-benchmark

Conversation

@acatangiu
Copy link
Copy Markdown
Contributor

@acatangiu acatangiu commented Mar 21, 2023 •
edited
Loading

Used by Bridge Hub Paras - see paritytech/cumulus#2353

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 21, 2023
@acatangiu acatangiu requested review from KiChjang and bkontur March 21, 2023 09:06
@acatangiu acatangiu self-assigned this Mar 21, 2023
@acatangiu acatangiu mentioned this pull request Mar 21, 2023
Closed
@acatangiu acatangiu added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label Mar 21, 2023
@acatangiu acatangiu mentioned this pull request Mar 21, 2023
Closed
bkontur
bkontur reviewed Mar 21, 2023
View reviewed changes
@acatangiu acatangiu force-pushed the xcm-exportmessage-benchmark branch from 426face to 6f8cedc Compare March 21, 2023 09:28
@paritytech-ci paritytech-ci requested review from a team March 21, 2023 09:29
bkontur
bkontur reviewed Mar 21, 2023
View reviewed changes
@acatangiu
XCM ExportMessage benchmark support
fecbf12 
Signed-off-by: acatangiu <adrian@parity.io>
@acatangiu
address review comments
c0c5d55
@acatangiu acatangiu force-pushed the xcm-exportmessage-benchmark branch from 6f8cedc to c0c5d55 Compare March 21, 2023 12:29
@paritytech paritytech deleted a comment from paritytech-cicd-pr Mar 21, 2023
@acatangiu
Copy link
Copy Markdown
Contributor Author

acatangiu commented Mar 21, 2023

@paritytech/locks-review PR ready for review

ggwpez
ggwpez reviewed Mar 21, 2023
View reviewed changes
@paritytech-ci paritytech-ci requested a review from a team March 23, 2023 10:00
@acatangiu acatangiu merged commit 2bbef46 into paritytech:master Mar 23, 2023
ordian added a commit that referenced this pull request Mar 23, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-client
ed759e6 
* master:
  Bump parity-scale-codec to v 3.4.0 (#6945)
  XCM ExportMessage benchmark support (#6923)
  Vstam1/xcm admin origin (#6928)
  Ensure candidate-backing and provisioner exit on missing Overseer (#6939)
  move back to ci-linux@production image
  runtime/inclusion: fix availability_threshold (#6931)
  Companion for #13624 (#6924)
ordian added a commit that referenced this pull request Mar 23, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
fbc0e9d 
* master:
  Bump parity-scale-codec to v 3.4.0 (#6945)
  XCM ExportMessage benchmark support (#6923)
  Vstam1/xcm admin origin (#6928)
  Ensure candidate-backing and provisioner exit on missing Overseer (#6939)
  move back to ci-linux@production image
  runtime/inclusion: fix availability_threshold (#6931)
  Companion for #13624 (#6924)
@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Mar 23, 2023

CI in my MR is red now:

error[E0046]: not all trait items implemented, missing: `export_message_origin_and_destination`
    --> parachains/runtimes/assets/statemint/src/lib.rs:1002:4
     |
1002 |             impl pallet_xcm_benchmarks::generic::Config for Runtime {
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `export_message_origin_and_destination` in implementation
     |
     = help: implement the missing item: `fn export_message_origin_and_destination() -> std::result::Result<(cumulus_primitives_core::MultiLocation, cumulus_primitives_core::NetworkId, cumulus_primitives_core::Junctions), frame_benchmarking::BenchmarkError> { todo!() }`

error: could not document `statemint-runtime`

Weird that the CI here did not catch it. You can push directly to paritytech/cumulus#2346

@acatangiu
Copy link
Copy Markdown
Contributor Author

acatangiu commented Mar 23, 2023

Oh, right, CI missed it because it only errors on --features runtime-benchmarks which the companion doesn't check..

@acatangiu
Copy link
Copy Markdown
Contributor Author

acatangiu commented Mar 23, 2023

Pushed the fix directly to paritytech/cumulus#2346

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@bkontur bkontur bkontur left review comments

@gavofyork gavofyork gavofyork approved these changes

@KiChjang KiChjang KiChjang approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@acatangiu acatangiu

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@acatangiu @ggwpez @gavofyork @KiChjang @bkchr @bkontur