This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
davxy
added
A0-please_review
andresilva
approved these changes
Mar 16, 2023
koute
approved these changes
Mar 17, 2023
ordian
added a commit
that referenced
this pull request
Mar 21, 2023
* master: kusama: enable dispute slashes (#5974) Introduce OpenGov into Polkadot (#6701) introduce new well known key (#6915) [CI] Add bootnode checking CI jobs (#6889) Bump parity-db (#6921) Handling timers for repeat dispute participation requests (#6901) [Companion #13634] keystore overhaul (iter2) (#6913) tweak some pattern matches to address a new clippy warning Bump ci-linux image for rust 1.68 Revert "Update orchestra to the recent version (#6854)" (#6916) Deprecate Currency: Companion for #12951 (#6780) changelog: template fixup (#6907) [Companion #13615] Keystore overhaul (#6892) update weights (#6897) Fix approval voting test (#6898) parachains-runtime: Less cloning! (#6896) Testing Reversion Speed on Dispute Concluded Against (#6880) remove duplicated arm and fix version index (#6884)
ordian
added a commit
that referenced
this pull request
Mar 21, 2023
* master: kusama: enable dispute slashes (#5974) Introduce OpenGov into Polkadot (#6701) introduce new well known key (#6915) [CI] Add bootnode checking CI jobs (#6889) Bump parity-db (#6921) Handling timers for repeat dispute participation requests (#6901) [Companion #13634] keystore overhaul (iter2) (#6913) tweak some pattern matches to address a new clippy warning Bump ci-linux image for rust 1.68 Revert "Update orchestra to the recent version (#6854)" (#6916) Deprecate Currency: Companion for #12951 (#6780) changelog: template fixup (#6907) [Companion #13615] Keystore overhaul (#6892) update weights (#6897) Fix approval voting test (#6898) parachains-runtime: Less cloning! (#6896) Testing Reversion Speed on Dispute Concluded Against (#6880) remove duplicated arm and fix version index (#6884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the keystore I found a small bug in one of the approval voting tests.
In the test, after we received the
CandidateValidationMessagewe send back theValidationResult.This will be received and processed by the subsystem
handle_actionsfunction here.Follows a call to
issue_approvalwhere theDistributeApprovalmessage is sent back here.There was a bug in the test preventing the keystore to be populated.
In practice we were using the async trait without calling await during the key generation.
This was making the test to silently early exit during the signing phase of the approval before sending the
DistributeApproval(was failing here)