Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

WIP: Run try-runtime hooks in CI#6491

Closed
ggwpez wants to merge 3 commits intomasterfrom
oty-try-runtime-checks
Closed

WIP: Run try-runtime hooks in CI#6491
ggwpez wants to merge 3 commits intomasterfrom
oty-try-runtime-checks

Conversation

@ggwpez
Copy link
Copy Markdown
Member

@ggwpez ggwpez commented Jan 2, 2023 •
edited
Loading

Repurposed: Run the try-runtime checks with more backtrace info as indicated in the CI output: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2606867

Going to test this by deploying the same migration twice.

@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels Jan 2, 2023
@ggwpez ggwpez requested review from a team and chevdor as code owners January 2, 2023 17:18
@paritytech-ci paritytech-ci requested a review from a team January 2, 2023 17:18
@ggwpez ggwpez mentioned this pull request Jan 2, 2023
Merged
kianenigma
kianenigma reviewed Jan 3, 2023
View reviewed changes
@ggwpez ggwpez added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label Jan 3, 2023
@paritytech-cicd-pr
Copy link
Copy Markdown

paritytech-cicd-pr commented Jan 3, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2217999

@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Jan 4, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Jan 4, 2023

Rebased

@ggwpez ggwpez changed the title Run try-runtime hooks in CI WIP: Run try-runtime hooks in CI Jan 4, 2023
This was referenced Jan 10, 2023
Closed
Closed
@kianenigma
Copy link
Copy Markdown
Contributor

kianenigma commented Feb 14, 2023

What's the status here?

@ggwpez ggwpez force-pushed the oty-try-runtime-checks branch from 93fe106 to 72309a2 Compare February 20, 2023 16:55
@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Feb 20, 2023

What's the status here?

That we probably need to add a new label for the release engies to use, since we cannot expect the try-runtime of master to work, in case Polkadot is not yet on the latest release.

We can add a way to demote the error of an pre_upgrade to a warning, which could improve development speed since we dont always need to re-build and re-try after removing each old migration. Then we either the warning for master and the error on release, or just warning everywhere 🤷
Having old migrations is not an "error" anyway. @kianenigma

@kiltbot kiltbot mentioned this pull request Feb 27, 2023
Closed
@ggwpez
ci: full backtrace for try-runtime
1682c34 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez force-pushed the oty-try-runtime-checks branch from 72309a2 to 1682c34 Compare March 29, 2023 15:45
@ggwpez
DNM: Add wrong migration
5341066 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Mar 30, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Mar 30, 2023

Rebased

@paritytech-ci paritytech-ci requested review from a team March 30, 2023 15:15
@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Mar 30, 2023

CI is not running here?!
Change is not really high prio rn so going to merge into the next MR.

@ggwpez ggwpez closed this Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chevdor chevdor Awaiting requested review from chevdor

1 more reviewer

@kianenigma kianenigma kianenigma left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggwpez @paritytech-cicd-pr @kianenigma