Refactors elections-phragmen pallet (companion for substrate#13453) by gpestana · Pull Request #6278 · paritytech/polkadot

gpestana · 2022-11-13T17:18:23Z

Companion for paritytech/substrate#13453

Cumulus companion: paritytech/cumulus#2217

…es to elections pallet runtime configs

kianenigma

Definitely want to see a good amount of doc about the pallet prefix, and hot it could lead to a migration, and how we won't need it here.

…but the lock id was not

kianenigma · 2022-12-08T13:40:45Z

Needs to be brought back to life.

kianenigma

Should keep the old pallet name in Polkadot and Kusama runtimes, but the crate name can still change.

…tech/polkadot into gpestana8250_npossolver_companion

gpestana · 2023-03-24T11:09:58Z

bot bench -v PATCH_substrate=13453 $ runtime polkadot-dev pallet_elections

command-bot · 2023-03-24T11:10:03Z

@gpestana "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections (https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583564) was cancelled in #6278 (comment)

gpestana · 2023-03-24T11:39:10Z

bot cancel 38-d29b67b0-4859-4765-a173-1c90c2ac9602

command-bot · 2023-03-24T11:39:19Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583564 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583564/artifacts/download.

gpestana · 2023-03-24T11:40:09Z

bot bench -v PATCH_substrate=13453 $ runtime polkadot-dev pallet_elections

command-bot · 2023-03-24T11:40:15Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583937 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 39-a5a4e7fa-9118-4938-930b-fbfbe5dda7f7 to cancel this command or bot cancel to cancel all commands in this pull request.

…lections

command-bot · 2023-03-24T17:58:20Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583937 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583937/artifacts/download.

gpestana · 2023-03-24T18:54:23Z

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

command-bot · 2023-03-24T18:54:28Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2587655 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 42-ac6a1209-f80e-4098-ad36-f4455ec315a4 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-03-24T19:02:17Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2587655 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2587655/artifacts/download.

gpestana · 2023-03-25T19:14:48Z

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

command-bot · 2023-03-25T19:14:53Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2590313 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 45-d72dd759-7703-4cd3-8bed-cacb3cabcd59 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-03-25T19:22:41Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2590313 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2590313/artifacts/download.

gpestana · 2023-05-01T10:42:45Z

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

command-bot · 2023-05-01T10:42:49Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756720 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-845e819a-e3a2-45ec-8f93-fba2d93b6801 to cancel this command or bot cancel to cancel all commands in this pull request.

paritytech-cicd-pr · 2023-05-01T10:43:04Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756531

command-bot · 2023-05-01T10:43:34Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756720 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756720/artifacts/download.

gpestana · 2023-05-01T13:46:08Z

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

command-bot · 2023-05-01T13:46:13Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2757705 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-67ac322a-f028-4e0f-9619-db03e0062f66 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-05-01T14:27:16Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2757705 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2757705/artifacts/download.

Renamed pallet elections_phragmen to elections; Adds required new typ…

90a1f90

…es to elections pallet runtime configs

gpestana marked this pull request as draft November 13, 2022 17:18

github-actions bot added the A0-please_review Pull request needs code review. label Nov 13, 2022

paritytech-ci requested review from a team November 13, 2022 17:18

gpestana mentioned this pull request Nov 13, 2022

Abstracts elections-phragmen pallet to use NposSolver paritytech/substrate#12588

Merged

6 tasks

gpestana added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Nov 14, 2022

kianenigma suggested changes Nov 17, 2022

View reviewed changes

gpestana added 2 commits November 17, 2022 14:50

updates runtime pallet elections weights

5588c3e

adds comments explaining why elections pallet param type was renamed …

b6baf7d

…but the lock id was not

gpestana requested a review from kianenigma November 20, 2022 15:02

gpestana added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Nov 20, 2022

gpestana marked this pull request as ready for review November 20, 2022 16:09

paritytech-ci requested a review from a team November 20, 2022 16:09

gpestana added B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed B1-releasenotes labels Dec 8, 2022

gpestana self-assigned this Dec 8, 2022

Merge branch 'master' into gpestana8250_npossolver_companion

3544937

the-right-joyce added B1-note_worthy T0-node This PR/Issue is related to the topic “node”. T1-runtime This PR/Issue is related to the topic “runtime”. labels Dec 14, 2022

kianenigma reviewed Jan 16, 2023

View reviewed changes

paritytech-ci requested a review from a team January 16, 2023 19:10

the-right-joyce removed the B1-releasenotes label Jan 20, 2023

gpestana added 5 commits March 22, 2023 18:20

Merge branch 'master' into gpestana8250_npossolver_companion

fd64eec

fixes from merge commit

14a571e

Merge branch 'gpestana8250_npossolver_companion' of github.com:parity…

086b2b6

…tech/polkadot into gpestana8250_npossolver_companion

Merge branch 'master' into gpestana8250_npossolver_companion

a0f0fee

Adds missing NposSolver

4f100c6

Moves NposSolver import under tests

bd51835

".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet_e…

5cd574a

…lections

Merge branch 'master' into gpestana8250_npossolver_companion

31b78a8

kianenigma self-requested a review April 10, 2023 12:26

Merge branch 'master' into gpestana8250_npossolver_companion

6afac5f

Conversation

gpestana commented Nov 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

kianenigma commented Dec 8, 2022

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

gpestana commented Mar 24, 2023

Uh oh!

command-bot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpestana commented Mar 24, 2023

Uh oh!

command-bot bot commented Mar 24, 2023

Uh oh!

gpestana commented Mar 24, 2023

Uh oh!

command-bot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 24, 2023

Uh oh!

gpestana commented Mar 24, 2023

Uh oh!

command-bot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 24, 2023

Uh oh!

gpestana commented Mar 25, 2023

Uh oh!

command-bot bot commented Mar 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 25, 2023

Uh oh!

gpestana commented May 1, 2023

Uh oh!

command-bot bot commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paritytech-cicd-pr commented May 1, 2023

Uh oh!

command-bot bot commented May 1, 2023

Uh oh!

gpestana commented May 1, 2023

Uh oh!

command-bot bot commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented May 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gpestana commented Nov 13, 2022 •

edited

Loading

command-bot bot commented Mar 24, 2023 •

edited

Loading

command-bot bot commented Mar 24, 2023 •

edited

Loading

command-bot bot commented Mar 24, 2023 •

edited

Loading

command-bot bot commented Mar 25, 2023 •

edited

Loading

command-bot bot commented May 1, 2023 •

edited

Loading

command-bot bot commented May 1, 2023 •

edited

Loading