update weights (0.9.31) by coderobe · Pull Request #6173 · paritytech/polkadot

coderobe · 2022-10-21T07:44:41Z

let's find out if they're good this time around! 🏋️‍♀️

EgorPopelyaev

There are a lot of big jumps again from 0 to billion values

EgorPopelyaev · 2022-10-21T08:11:38Z

runtime/kusama/src/weights/frame_election_provider_support.rs

-			.saturating_add(Weight::from_ref_time(13_944_000 as u64).saturating_mul(v as u64))
-			// Standard Error: 4_876_000
-			.saturating_add(Weight::from_ref_time(2_223_649_000 as u64).saturating_mul(d as u64))
+		Weight::from_ref_time(5_472_372_000 as u64)


big jump from 0 -> 5_472_372_000

EgorPopelyaev · 2022-10-21T08:12:04Z

runtime/kusama/src/weights/frame_election_provider_support.rs

-			.saturating_add(Weight::from_ref_time(14_480_000 as u64).saturating_mul(v as u64))
-			// Standard Error: 6_844_000
-			.saturating_add(Weight::from_ref_time(2_525_332_000 as u64).saturating_mul(d as u64))
+		Weight::from_ref_time(4_270_710_000 as u64)


same here from 0 -> 4_270_710_000

Even the worst case improvement is 31.8% here, so it is better now.
The crux is that the components do not start at 0, as you can see code comment above the function.
SWC now evaluates both formulas at all corners and compares them to find the worst case improvement. In this case:

27106660000 vs 18355259455 (-32.285056679797506) [d = 5, v = 1.00K] 41586660000 vs 23769227455 (-42.844105645897024) [d = 5, v = 2.00K] 54885312000 vs 37430538656 (-31.802266777676323) [d = 16, v = 1.00K] 69365312000 vs 42844506656 (-38.233527074743066) [d = 16, v = 2.00K]

EgorPopelyaev · 2022-10-21T08:15:58Z

runtime/kusama/src/weights/pallet_election_provider_multi_phase.rs

-			// Standard Error: 17_000
-			.saturating_add(Weight::from_ref_time(180_000 as u64).saturating_mul(d as u64))
+	fn elect_queued(a: u32, _d: u32, ) -> Weight {
+		Weight::from_ref_time(389_938_000 as u64)


0 -> 389_938_000

EgorPopelyaev · 2022-10-21T08:16:17Z

runtime/kusama/src/weights/pallet_election_provider_multi_phase.rs

-			// Standard Error: 35_000
-			.saturating_add(Weight::from_ref_time(2_257_000 as u64).saturating_mul(d as u64))
+	fn submit_unsigned(_v: u32, _t: u32, a: u32, _d: u32, ) -> Weight {
+		Weight::from_ref_time(6_923_558_000 as u64)


0 -> 6_923_558_000

EgorPopelyaev · 2022-10-21T08:16:31Z

runtime/kusama/src/weights/pallet_election_provider_multi_phase.rs

-			// Standard Error: 63_000
-			.saturating_add(Weight::from_ref_time(1_598_000 as u64).saturating_mul(d as u64))
+	fn feasibility_check(v: u32, _t: u32, a: u32, _d: u32, ) -> Weight {
+		Weight::from_ref_time(6_146_628_000 as u64)


again 0 -> 6_146_628_000

EgorPopelyaev · 2022-10-21T08:58:05Z

runtime/westend/src/weights/pallet_staking.rs

-			.saturating_add(Weight::from_ref_time(24_156_000 as u64).saturating_mul(n as u64))
-			.saturating_add(T::DbWeight::get().reads(187 as u64))
-			.saturating_add(T::DbWeight::get().reads((5 as u64).saturating_mul(v as u64)))
+		Weight::from_ref_time(441_118_000 as u64)


0 -> 441_118_000

EgorPopelyaev · 2022-10-21T08:58:17Z

runtime/westend/src/weights/pallet_staking.rs

-			.saturating_add(T::DbWeight::get().reads((4 as u64).saturating_mul(n as u64)))
-			.saturating_add(T::DbWeight::get().reads((1 as u64).saturating_mul(s as u64)))
+	fn get_npos_voters(v: u32, n: u32, _s: u32, ) -> Weight {
+		Weight::from_ref_time(25_869_841_000 as u64)


0 -> 25_869_841_000

EgorPopelyaev · 2022-10-21T08:58:29Z

runtime/westend/src/weights/pallet_staking.rs

-			.saturating_add(Weight::from_ref_time(6_515_000 as u64).saturating_mul(v as u64))
-			.saturating_add(T::DbWeight::get().reads(2 as u64))
-			.saturating_add(T::DbWeight::get().reads((1 as u64).saturating_mul(v as u64)))
+		Weight::from_ref_time(3_445_194_000 as u64)


0 -> 3_445_194_000

EgorPopelyaev · 2022-10-21T09:00:33Z

runtime/westend/src/weights/runtime_common_slots.rs

-			.saturating_add(T::DbWeight::get().writes(1 as u64))
-			.saturating_add(T::DbWeight::get().writes((1 as u64).saturating_mul(c as u64)))
-			.saturating_add(T::DbWeight::get().writes((3 as u64).saturating_mul(t as u64)))
+		Weight::from_ref_time(548_530_000 as u64)


0 -> 548_530_000

EgorPopelyaev · 2022-10-21T09:01:04Z

runtime/westend/src/weights/runtime_parachains_hrmp.rs

-			.saturating_add(T::DbWeight::get().writes(4 as u64))
-			.saturating_add(T::DbWeight::get().writes((3 as u64).saturating_mul(i as u64)))
-			.saturating_add(T::DbWeight::get().writes((3 as u64).saturating_mul(e as u64)))
+		Weight::from_ref_time(859_684_000 as u64)


0 -> 859_684_000

chevdor · 2022-10-21T10:12:30Z

SWC link: https://weights.tasty.limo/compare?old=v0.9.30&new=coderobe%2Fweights-31&threshold=30&unit=time&repo=polkadot&path_pattern=runtime%2F**%2Fsrc%2Fweights%2F**%2F*.rs&method=guess-worst&ignore_errors=true

(link updated)

cc @ggwpez

ggwpez · 2022-10-21T11:14:55Z

SWC link: https://weights.tasty.limo/compare?old=v0.9.30&new=release-v0.9.31&threshold=30&unit=time&repo=polkadot&path_pattern=runtime/**/src/weights/**/*.rs&method=guess-worst&ignore_errors=true

cc @ggwpez

That compares against release-v0.9.31 but this MR is against coderobe/weights-31. @chevdor

ggwpez · 2022-10-21T15:35:40Z

runtime/kusama/src/weights/runtime_parachains_hrmp.rs

+			.saturating_add(T::DbWeight::get().reads(256 as u64))
+			.saturating_add(T::DbWeight::get().reads((1 as u64).saturating_mul(i as u64)))
+			.saturating_add(T::DbWeight::get().reads((1 as u64).saturating_mul(e as u64)))
+			.saturating_add(T::DbWeight::get().writes(384 as u64))


We cannot use that. Same problem as here paritytech/cumulus#1784
And should be fixed in paritytech/substrate#12482

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

coderobe added 4 commits October 21, 2022 09:42

kusama: update weights

fec621b

polkadot: update weights

9122526

westend: update weights

087cb4b

rococo: update weights

5c41c2c

coderobe added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 21, 2022

coderobe requested review from EgorPopelyaev and chevdor October 21, 2022 07:44

coderobe mentioned this pull request Oct 21, 2022

Polkadot v0.9.31 Release checklist #6169

Closed

14 tasks

EgorPopelyaev reviewed Oct 21, 2022

View reviewed changes

coderobe requested a review from ggwpez October 21, 2022 09:04

ggwpez reviewed Oct 21, 2022

View reviewed changes

ggwpez mentioned this pull request Oct 21, 2022

New Weights for All Pallets paritytech/substrate#12325

Merged

Add dependencies

8c6970c

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez mentioned this pull request Oct 24, 2022

Update pallet-multisig benches paritytech/substrate#12558

Merged

coderobe mentioned this pull request Oct 26, 2022

update weights, attempt two (0.9.31) #6189

Merged

coderobe closed this Oct 26, 2022

coderobe deleted the coderobe/weights-31 branch January 16, 2023 14:41

Conversation

coderobe commented Oct 21, 2022

Uh oh!

EgorPopelyaev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggwpez Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chevdor commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggwpez commented Oct 21, 2022

Uh oh!

ggwpez Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ggwpez Oct 21, 2022 •

edited

Loading

chevdor commented Oct 21, 2022 •

edited

Loading

ggwpez Oct 21, 2022 •

edited

Loading