This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make Treasurer origin able to spend any amount#6138
Closed
amarsinghcodes wants to merge 1 commit intoparitytech:masterfrom
Closed
Make Treasurer origin able to spend any amount#6138amarsinghcodes wants to merge 1 commit intoparitytech:masterfrom
amarsinghcodes wants to merge 1 commit intoparitytech:masterfrom
Conversation
Member
|
Could you provide some test? :D |
Contributor
Author
|
#6372 makes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc comment above
Treasurerorigin says "Origin for spending (any amount of) funds", but the origin is not set anywhere in the Kusama runtime.The pallet_treasury::Config::SpendOrigin = TreasurySpender = EitherOf<Root, Spender> so I think
Treasurerorigin needs to be added to Spender.Without this change, I don't see how the
Treasurerorigin/track can do anything.