This repository was archived by the owner on Nov 15, 2023. It is now read-only.
sudo call to establish hrmp channel#4998
Closed
stanly-johnson wants to merge 3 commits intoparitytech:masterfrom
Closed
sudo call to establish hrmp channel#4998stanly-johnson wants to merge 3 commits intoparitytech:masterfrom
stanly-johnson wants to merge 3 commits intoparitytech:masterfrom
Conversation
bkchr
approved these changes
Feb 27, 2022
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
pepyakin
approved these changes
Feb 28, 2022
Contributor
pepyakin
left a comment
pepyakin
left a comment
There was a problem hiding this comment.
Thanks,
One thing that we could be done here or in a follow-up is to see if we can remove this function from paras_sudo_wrapper to avoid duplication.
Contributor
|
Would be nice to pass the |
gilescope
added
A0-please_review
|
@stanly-johnson , do you think that you can address this comment from joe? I think this feature will very simplify the usage for opening hrmp channels. |
shawntabrizi
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4648