Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion for Substrate#10445#4506

Merged
acatangiu merged 2 commits intoparitytech:masterfrom
acatangiu:companion-10445
Dec 21, 2021
Merged

Companion for Substrate#10445#4506
acatangiu merged 2 commits intoparitytech:masterfrom
acatangiu:companion-10445

Conversation

@acatangiu
Copy link
Copy Markdown
Contributor

@acatangiu acatangiu commented Dec 10, 2021

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Dec 10, 2021
@acatangiu acatangiu self-assigned this Dec 10, 2021
@acatangiu acatangiu mentioned this pull request Dec 10, 2021
Merged
@joao-paulo-parity joao-paulo-parity mentioned this pull request Dec 21, 2021
Closed
@acatangiu
Copy link
Copy Markdown
Contributor Author

acatangiu commented Dec 21, 2021

bot merge

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Dec 21, 2021

Error:
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Batch: Availability and Validity' does not match any projects in polkadot's Process.json
  • 'Batch: Codebase Restructure' does not match any projects in polkadot's Process.json

Merge failed. Check out the criteria for merge. If you're not meeting the approval count, check if the approvers are members of substrateteamleads or core-devs.

@acatangiu acatangiu requested review from adoerr and tomusdrw December 21, 2021 15:30
@sandreim
Copy link
Copy Markdown
Contributor

sandreim commented Dec 21, 2021

bot merge

@ordian
Copy link
Copy Markdown

ordian commented Dec 21, 2021 •
edited
Loading

please run git merge master and cargo update -p sp-io

usually these commands are run by bot, but you merged substrate PR manually

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Dec 21, 2021

Error: Checks failed for a1361ef

@acatangiu acatangiu merged commit 69b890c into paritytech:master Dec 21, 2021
ordian added a commit that referenced this pull request Dec 22, 2021
@ordian
Merge branch 'master' into ao-session-info-3227
070ba68 
* master:
  Fix currently-checking-cache (#4410)
  Companion for Substrate#10445 (#4506)
  pvf-precheck: update rustdoc for paras module (#4459)
ordian added a commit that referenced this pull request Dec 22, 2021
@ordian
Merge branch 'master' into ao-session-info-migration
f51b27d 
* master:
  Fix currently-checking-cache (#4410)
  Companion for Substrate#10445 (#4506)
  pvf-precheck: update rustdoc for paras module (#4459)
drahnr pushed a commit that referenced this pull request Jan 4, 2022
@acatangiu @drahnr
Companion for Substrate#10445 (#4506)
2a6ea44 
* runtimes: use updated BeefyApi

* update lockfile for substrate
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
@acatangiu @Wizdave97
Companion for Substrate#10445 (paritytech#4506)
29e0711 
* runtimes: use updated BeefyApi

* update lockfile for substrate
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@adoerr adoerr Awaiting requested review from adoerr

2 more reviewers

@ordian ordian ordian approved these changes

@sandreim sandreim sandreim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@acatangiu acatangiu

Labels

A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acatangiu @sandreim @ordian