This repository was archived by the owner on Nov 15, 2023. It is now read-only.
pvf-precheck: Candidate Validation Changes#4409
Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open. |
This was referenced Nov 29, 2021
pepyakin
added
B0-silent
Base automatically changed from
pep-primitives-pvf-check-statement
to
master
November 30, 2021 10:32
pepyakin
force-pushed
the
pep-precheck-candidate-validation
branch
3 times, most recently
from
7afadb3 to
19f746f
Compare
Co-authored-by: Chris Sosnin <chris125_@live.com>
pepyakin
force-pushed
the
pep-precheck-candidate-validation
branch
from
19f746f to
9c18425
Compare
3 tasks
drahnr
approved these changes
Nov 30, 2021
rphmeier
approved these changes
Nov 30, 2021
drahnr
pushed a commit
that referenced
this pull request
Dec 1, 2021
* pvf-precheck: Candidate Validation Changes Co-authored-by: Chris Sosnin <chris125_@live.com> * Rename `MockValidationBackend` and specialize it * Add pre-check tests Co-authored-by: Chris Sosnin <chris125_@live.com>
drahnr
pushed a commit
that referenced
this pull request
Dec 1, 2021
* pvf-precheck: Candidate Validation Changes Co-authored-by: Chris Sosnin <chris125_@live.com> * Rename `MockValidationBackend` and specialize it * Add pre-check tests Co-authored-by: Chris Sosnin <chris125_@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of #3211.
As part of this PR we are integrating the new validation host function,
that is
precheck_pvf, into the candidate-validation subsystem, which willbe the main entrypoint for pre-checking subsystem (To be introduced by
PRs down the stack).
skip check-dependent-cumulus