This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Improve paras runtime BenchBuilder api#4318
Merged
paritytech-processbot[bot] merged 19 commits intomasterfrom Dec 2, 2021
Merged
Improve paras runtime BenchBuilder api#4318paritytech-processbot[bot] merged 19 commits intomasterfrom
BenchBuilder api#4318paritytech-processbot[bot] merged 19 commits intomasterfrom
Conversation
emostov
added
B0-silent
drahnr
reviewed
Nov 18, 2021
drahnr
reviewed
Nov 18, 2021
Lldenaurois
approved these changes
Nov 25, 2021
drahnr
reviewed
Nov 25, 2021
drahnr
reviewed
Nov 25, 2021
drahnr
reviewed
Nov 25, 2021
drahnr
reviewed
Nov 25, 2021
drahnr
approved these changes
Nov 25, 2021
Contributor
drahnr
left a comment
drahnr
left a comment
There was a problem hiding this comment.
A few nits, mostly about docs and ergonomic API - other than that LGTM, it's going to be a big improvement!
rphmeier
approved these changes
Nov 29, 2021
Contributor
|
@emostov Will you address review comments? Nits & suggestions |
Contributor
|
Resolved the last nits. |
Contributor
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for e35c7bf |
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Dec 3, 2021
* master: (23 commits) Fix path of the polkadot_injected docker image (#4463) update docs on `validation_upgrade_frequency` (#4460) Fix path of the polkadot sha256 (#4458) Fix cumulus companion CI job (#4451) Add doc about runtime version bump (#4418) Bump trybuild from 1.0.52 to 1.0.53 (#4455) companion for #10231 (#4306) trivial fix (#4441) Rococo: ability to programatically assign slots to teams (#3943) Add parent header hash to log (#4421) bump tx versions (#4447) Companion for substrate/10347 (#4413) Improve paras runtime `BenchBuilder` api (#4318) Add CI team to `CODEOWNERS` file (#4350) XCM Benchmarks for Generic Instructions (#3940) Announce only on releases (#4417) Companion for 10379 (EnsureOneOf) (#4405) add pallet-babe/std (#4438) update Cargo.lock Squashed 'bridges/' changes from 407bf44a8a..1602249f0a ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily improves the
BenchBuilder::buildAPI by not requiring the user to left pad thedispute_sessionsinput to account for the cores used forbacked_and_concluding.