This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
Adds bumping spec_version and version in Cargo.toml to the checklist after publishing a release.
s3krit
added
A2-insubstantial
bkchr
approved these changes
Nov 12, 2021
chevdor
suggested changes
Nov 12, 2021
Contributor
chevdor
left a comment
chevdor
left a comment
There was a problem hiding this comment.
I will come up with a suggestion
| draft-release | ||
| - [ ] Once the new release has been published, bump `spec_version` in Polkadot, Westend and Kusama. | ||
| - [ ] Once the new releaes has been published, bump the version string in various `Cargo.toml` files | ||
| - For example, bumping v0.9.12 to v0.9.13: `grep -rl '^version = "0.9.12"' ./**/Cargo.toml | xargs sed -i 's/^version = "0.9.12"/version = "0.9.13"/g'` |
Contributor
There was a problem hiding this comment.
The command "as is" does not work on MacOS. I am testing a small variation.
chevdor
reviewed
Nov 12, 2021
| draft-release | ||
| - [ ] Once the new release has been published, bump `spec_version` in Polkadot, Westend and Kusama. | ||
| - [ ] Once the new releaes has been published, bump the version string in various `Cargo.toml` files | ||
| - For example, bumping v0.9.12 to v0.9.13: `grep -rl '^version = "0.9.12"' ./**/Cargo.toml | xargs sed -i 's/^version = "0.9.12"/version = "0.9.13"/g'` |
Contributor
There was a problem hiding this comment.
Would the following work for you as well ?
Suggested change
| - For example, bumping v0.9.12 to v0.9.13: `grep -rl '^version = "0.9.12"' ./**/Cargo.toml | xargs sed -i 's/^version = "0.9.12"/version = "0.9.13"/g'` | |
| - For example, bumping v0.9.12 to v0.9.13: `grep -rl '^version = "0.9.12"' ./**/Cargo.toml | xargs sed -i '' -e 's/^version = "0.9.12"/version = "0.9.13"/g'` |
Contributor
Author
There was a problem hiding this comment.
Think the suggestion went a bit wonky - are you suggesting to swap -i for -e?
Contributor
There was a problem hiding this comment.
no no, as it shows: to explicitely tell -i to be empty and -e to the previous content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bumping spec_version and version in Cargo.toml to the checklist after publishing a release.