This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
ordian
added
A2-insubstantial
drahnr
reviewed
Oct 18, 2021
| /// | ||
| /// - On incoming overseer messages, it starts or stops jobs as appropriate. | ||
| /// - On other incoming messages, if they can be converted into Job::ToJob and | ||
| /// - On other incoming messages, if they can be converted into `Job::ToJob` and |
drahnr
reviewed
Oct 18, 2021
| #[derive(thiserror::Error, Debug)] | ||
| pub enum Error { | ||
| #[error("Oneshot was cancelled.")] | ||
| #[error("Oneshot was canceled.")] |
Contributor
There was a problem hiding this comment.
drahnr
reviewed
Oct 18, 2021
| /// This functions modifies the state when failing. It is expected to be called in inherent, | ||
| /// and to fail the extrinsic on error. As invalid inherents are not allowed, the dirty state | ||
| /// is not commited. | ||
| /// is not committed. |
drahnr
approved these changes
Oct 18, 2021
Contributor
drahnr
left a comment
drahnr
left a comment
There was a problem hiding this comment.
LGTM, added a link about cancelled apparently being OK as well
Contributor
|
bot merge |
|
Error: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information. |
ordian
added a commit
that referenced
this pull request
Oct 27, 2021
* master: (73 commits) Fix XCM Teleport Benchmark (#4146) Allow Queries and Subscriptions (#4150) Fix weights on hard-coded XCM fragments (#4144) Bump spec versions (#4142) Bump libc from 0.2.104 to 0.2.105 (#4141) Enable bags-list pallet in polkadot (#4080) Move artifacts states into memory in PVF validation host (#3907) Introduce new Runtime API endpoint for fetching the validation data (#3728) export xcm_pallet config (#4116) Apply cargo fmt (#4122) remove logging from the check-dependent-* job (#4120) Remove stale migrations (#4107) Bump structopt from 0.3.23 to 0.3.25 (#4098) remove hardcoded pipeline scripts tag (#4109) Bump libc from 0.2.103 to 0.2.104 (#4099) some spelling fixes (#4088) polkadot: remove call filters on registrar pallets (#4093) Fix typos in docs (#4092) Rename Statemint where appropriate (#4087) bump substrate (#4091) ...
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* quotes around Job::ToJob * add new words to dictionary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://gitlab.parity.io/parity/polkadot/-/jobs/1175947.