This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fix restart issue of staking miner#4073
Merged
kianenigma merged 10 commits intomasterfrom Oct 14, 2021
Merged
Conversation
Contributor
kianenigma
commented
Oct 13, 2021
kianenigma
commented
- fixes Staking miner: handle websocket termination #3738 hopefully
- helps with Staking miner: Check the queue one last time before submission #3740 by making sure that we run feasibility at least inside the block in which we mine the solution.
kianenigma
added
A0-please_review
niklasad1
reviewed
Oct 13, 2021
niklasad1
reviewed
Oct 13, 2021
niklasad1
reviewed
Oct 13, 2021
niklasad1
reviewed
Oct 13, 2021
niklasad1
reviewed
Oct 13, 2021
niklasad1
reviewed
Oct 13, 2021
niklasad1
approved these changes
Oct 13, 2021
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
LGTM but I'm not super familiar with the code
emostov
reviewed
Oct 14, 2021
emostov
reviewed
Oct 14, 2021
emostov
approved these changes
Oct 14, 2021
Contributor
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
lgtm, just a few comments/ questions
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
* master: (40 commits) use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071) Move runtime to with_transaction in order to Rollback state changes (#4067) Update wasmtime config to match new version in substrate (#4063) Fix XCM Weights on Westend (#4066) Dispatchable XCMs should translate to v0 (#4062) Add xcm fuzzer (#3869) Bump trybuild from 1.0.49 to 1.0.50 (#4060) Companion PR for ss58 crate (#3953) overseer: simplify debugging some more (#4053) Bump thiserror from 1.0.29 to 1.0.30 (#4048) Bump strum from 0.21.0 to 0.22.0 (#4047) Add para pallets to polkadot benchmarks (#4045) Fixes broken docker link in docker descriptiob (#4043) Bump trybuild from 1.0.48 to 1.0.49 (#4039) ...
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
…lkadot * master: use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
Co-authored-by: Niklas Adolfsson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.