Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Update wasmtime config to match new version in substrate #4063

Merged
3 commits merged into from
Oct 12, 2021
Merged

Update wasmtime config to match new version in substrate #4063

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4253c13
Update wasmtime config to match new version
slumber Oct 12, 2021
043cbf4
Merge remote-tracking branch 'origin/master' into slumber-update-subs…
Oct 12, 2021
757a622
update Substrate
Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion node/core/pvf/src/executor_intf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ const CONFIG: Config = Config {
// wasm pages.
//
// Thus let's assume that 32 pages or 2 MiB are used for these needs.
max_memory_pages: Some(2048 + 32),
//
// Note that the memory limit is specified in bytes, so we multiply this value
// by wasm page size -- 64 KiB.
max_memory_size: Some((2048 + 32) * 65536),
heap_pages: 2048,

allow_missing_func_imports: true,
Expand All @@ -65,6 +68,7 @@ const CONFIG: Config = Config {
native_stack_max: 256 * 1024 * 1024,
}),
canonicalize_nans: true,
parallel_compilation: true,
Copy link
Copy Markdown

@ordian ordian Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want single-threaded compilation?

Copy link
Copy Markdown
Contributor Author

@slumber slumber Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to turn it on when performing PVF prechecking, it can be introduced here (pass different semantics):

polkadot/node/core/pvf/src/executor_intf.rs

Line 88 in 4253c13

sc_executor_wasmtime::prepare_runtime_artifact(blob, &CONFIG.semantics)

Otherwise, the multithreaded behavior remains

},
};

Expand Down