This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
ordian
added
A0-please_review
rphmeier
approved these changes
Oct 2, 2021
Contributor
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
to Lldenaurois/polkadot
that referenced
this pull request
Oct 2, 2021
* master: preserve finalized block in active leaves (paritytech#3997) some tweaks to rococo-local (paritytech#3996) always broadcast tranche 0 assignments and add a delay before approval (paritytech#3904) Tidy up XCM errors in preparation for v2. (paritytech#3988) add disputes call to Rococo (paritytech#3993) Fix an off-by-one: revert rather than revert-to (paritytech#3991) add logs to relay chain selection (paritytech#3990) av-store: clean up StoreAvailableData message (paritytech#3984) add polkadot-simnet runner (paritytech#3985) Remove incorrect proof about Jemalloc (paritytech#3982) add new rococo chainspec (paritytech#3976) bump async-std's version to remove conflict for substrate (paritytech#3981) gossip-support: set last_session_index earlier (paritytech#3978)
bkchr
reviewed
Oct 2, 2021
| vec
There was a problem hiding this comment.
This will probably break tons of stuff, like tutorials and what else. Everything assumes 2 authorities. Could you please revert this.
You could just copy the function and have a different chain spec for your testing.
Author
There was a problem hiding this comment.
Thank you for the catch! Do you think we could reuse wococo-local for that as we currently disable bridges modules in rococo runtime, so it doesn't serve its original purpose?
Member
There was a problem hiding this comment.
I would have used a custom chain spec name (as you can use whatever you want), but as wococo isn't used currently it should be fine as well.
ordian
added a commit
that referenced
this pull request
Oct 3, 2021
* master: (72 commits) change genesis authority set for wococo-local, revert rococo-local (#3998) ignore irrelevant approvals in logs (#3859) avoid expect, on free availability core (#3994) preserve finalized block in active leaves (#3997) some tweaks to rococo-local (#3996) always broadcast tranche 0 assignments and add a delay before approval (#3904) Tidy up XCM errors in preparation for v2. (#3988) add disputes call to Rococo (#3993) Fix an off-by-one: revert rather than revert-to (#3991) add logs to relay chain selection (#3990) av-store: clean up StoreAvailableData message (#3984) add polkadot-simnet runner (#3985) Remove incorrect proof about Jemalloc (#3982) add new rococo chainspec (#3976) bump async-std's version to remove conflict for substrate (#3981) gossip-support: set last_session_index earlier (#3978) Companion for substrate PR#9890 (#3961) Bump version, tx_version and spec_version in prep for v0.9.11 (#3970) Fix master compilation (#3977) Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627) ...
ordian
added a commit
that referenced
this pull request
Oct 5, 2021
* master: (138 commits) Allow an Offset to Lease Periods (#3980) Bump quote from 1.0.9 to 1.0.10 (#4013) Companion for #9834 (Transaction Priority) (#3901) chore: update `builder` image (#3884) Free disputed cores before processing bitfields (#4008) Make candidate validation timeouts configurable (#4001) Add extrinsic ordering filtering (#3631) chore: ci list files that spellcheck finds (#3992) Use background tasks properly in candidate-validation (#4002) Fix unoccupied bitfields (#4004) Bump syn from 1.0.77 to 1.0.78 (#4006) Bump jsonrpsee-ws-client from 0.3.0 to 0.3.1 (#3931) fix clock drift for assignments issued before the block (#3851) Remove unoccupied bit check (#3999) bump substrate (#4000) change genesis authority set for wococo-local, revert rococo-local (#3998) ignore irrelevant approvals in logs (#3859) avoid expect, on free availability core (#3994) preserve finalized block in active leaves (#3997) some tweaks to rococo-local (#3996) ...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 validators with 1 size backing group. This is useful for disputes and simnet testing.