Companion to Substrate #9829 (Add `put_in_front_of` extrinsic to bags-list) by emostov · Pull Request #3899 · paritytech/polkadot

emostov · 2021-09-21T03:55:20Z

…nion

gui1117

looks good to me, as long as we keep an eye on it so weight is for sure updated in next runtime upgrade

gui1117 · 2021-12-03T04:55:07Z

runtime/kusama/src/weights/pallet_bags_list.rs

 	}
+	fn put_in_front_of() -> Weight {
+		0
+	}


so I guess we will upgrade in a follow up or before runtime upgrade, but we should be careful that we actually upgrade it.
Because it happens that system isn't updated by our release process (https://github.com/paritytech/polkadot/issues/4290) , so we should keep a careful eye on it.

Yup planning on doing a follow up immediatley after this was merged

…nion

paritytech-processbot · 2021-12-08T04:35:52Z

Companion update failed: CommandFailed { cmd: "Command { std: "cargo" "update" "-v" "-p" "frame-try-runtime:0.10.0-dev" "-p" "beefy-merkle-tree:4.0.0-dev" "-p" "pallet-multisig:4.0.0-dev" "-p" "pallet-beefy:4.0.0-dev" "-p" "sp-authority-discovery:4.0.0-dev" "-p" "pallet-babe:4.0.0-dev" "-p" "pallet-grandpa:4.0.0-dev" "-p" "sp-wasm-interface:4.0.0-dev" "-p" "pallet-recovery:4.0.0-dev" "-p" "frame-support-procedural:4.0.0-dev" "-p" "sc-block-builder:0.10.0-dev" "-p" "pallet-assets:4.0.0-dev" "-p" "sc-network:0.10.0-dev" "-p" "sp-api:4.0.0-dev" "-p" "sp-keyring:4.0.0-dev" "-p" "sp-consensus:0.10.0-dev" "-p" "frame-benchmarking:4.0.0-dev" "-p" "sp-authorship:4.0.0-dev" "-p" "substrate-prometheus-endpoint:0.10.0-dev" "-p" "sp-externalities:0.10.0-dev" "-p" "pallet-staking:4.0.0-dev" "-p" "pallet-offences:4.0.0-dev" "-p" "sc-chain-spec:4.0.0-dev" "-p" "frame-executive:4.0.0-dev" "-p" "sp-blockchain:4.0.0-dev" "-p" "pallet-staking-reward-curve:4.0.0-dev" "-p" "sp-application-crypto:4.0.0-dev" "-p" "sp-consensus-vrf:0.10.0-dev" "-p" "sp-runtime-interface:4.0.0-dev" "-p" "frame-system:4.0.0-dev" "-p" "sc-tracing:4.0.0-dev" "-p" "pallet-utility:4.0.0-dev" "-p" "pallet-balances:4.0.0-dev" "-p" "pallet-treasury:4.0.0-dev" "-p" "sc-consensus-babe:0.10.0-dev" "-p" "sp-npos-elections:4.0.0-dev" "-p" "sp-trie:4.0.0-dev" "-p" "sp-rpc:4.0.0-dev" "-p" "substrate-test-utils-derive:0.10.0-dev" "-p" "pallet-bags-list:4.0.0-dev" "-p" "pallet-transaction-payment:4.0.0-dev" "-p" "pallet-mmr-primitives:4.0.0-dev" "-p" "try-runtime-cli:0.10.0-dev" "-p" "pallet-mmr:4.0.0-dev" "-p" "sc-transaction-pool-api:4.0.0-dev" "-p" "substrate-build-script-utils:3.0.0" "-p" "sc-utils:4.0.0-dev" "-p" "sp-core-hashing-proc-macro:4.0.0-dev" "-p" "pallet-nicks:4.0.0-dev" "-p" "pallet-collective:4.0.0-dev" "-p" "sc-peerset:4.0.0-dev" "-p" "beefy-primitives:4.0.0-dev" "-p" "sp-keystore:0.10.0-dev" "-p" "test-runner:0.9.0" "-p" "frame-support-procedural-tools:4.0.0-dev" "-p" "frame-system-benchmarking:4.0.0-dev" "-p" "pallet-bags-list-remote-tests:4.0.0-dev" "-p" "pallet-staking-reward-fn:4.0.0-dev" "-p" "sp-core:4.0.0-dev" "-p" "sc-network-gossip:0.10.0-dev" "-p" "remote-externalities:0.10.0-dev" "-p" "sc-cli:0.10.0-dev" "-p" "sc-tracing-proc-macro:4.0.0-dev" "-p" "sp-arithmetic:4.0.0-dev" "-p" "pallet-identity:4.0.0-dev" "-p" "pallet-vesting:4.0.0-dev" "-p" "sc-consensus-epochs:0.10.0-dev" "-p" "pallet-transaction-payment-rpc-runtime-api:4.0.0-dev" "-p" "pallet-timestamp:4.0.0-dev" "-p" "sp-offchain:4.0.0-dev" "-p" "sp-runtime-interface-proc-macro:4.0.0-dev" "-p" "sp-timestamp:4.0.0-dev" "-p" "frame-support-test-pallet:4.0.0-dev" "-p" "substrate-test-client:2.0.1" "-p" "pallet-im-online:4.0.0-dev" "-p" "sc-keystore:4.0.0-dev" "-p" "pallet-sudo:4.0.0-dev" "-p" "sc-telemetry:4.0.0-dev" "-p" "sc-offchain:4.0.0-dev" "-p" "pallet-elections-phragmen:5.0.0-dev" "-p" "sc-informant:0.10.0-dev" "-p" "sp-transaction-pool:4.0.0-dev" "-p" "sc-authority-discovery:0.10.0-dev" "-p" "sc-finality-grandpa:0.10.0-dev" "-p" "sp-serializer:4.0.0-dev" "-p" "sp-database:4.0.0-dev" "-p" "substrate-test-utils:4.0.0-dev" "-p" "sc-rpc-server:4.0.0-dev" "-p" "substrate-wasm-builder:5.0.0-dev" "-p" "sp-maybe-compressed-blob:4.1.0-dev" "-p" "sp-state-machine:0.10.0-dev" "-p" "sp-core-hashing:4.0.0-dev" "-p" "sc-consensus-manual-seal:0.10.0-dev" "-p" "sc-executor:0.10.0-dev" "-p" "sp-tracing:4.0.0-dev" "-p" "substrate-frame-rpc-system:4.0.0-dev" "-p" "sp-version-proc-macro:4.0.0-dev" "-p" "pallet-election-provider-multi-phase:4.0.0-dev" "-p" "sc-transaction-pool:4.0.0-dev" "-p" "frame-system-rpc-runtime-api:4.0.0-dev" "-p" "sp-consensus-babe:0.10.0-dev" "-p" "sp-finality-grandpa:4.0.0-dev" "-p" "generate-bags:4.0.0-dev" "-p" "sc-sync-state-rpc:0.10.0-dev" "-p" "sp-version:4.0.0-dev" "-p" "sp-session:4.0.0-dev" "-p" "sc-consensus-slots:0.10.0-dev" "-p" "sp-runtime:4.0.0-dev" "-p" "sp-block-builder:4.0.0-dev" "-p" "pallet-membership:4.0.0-dev" "-p" "frame-benchmarking-cli:4.0.0-dev" "-p" "sp-io:4.0.0-dev" "-p" "pallet-democracy:4.0.0-dev" "-p" "pallet-session-benchmarking:4.0.0-dev" "-p" "sc-executor-wasmi:0.10.0-dev" "-p" "pallet-bounties:4.0.0-dev" "-p" "sc-rpc-api:0.10.0-dev" "-p" "sp-staking:4.0.0-dev" "-p" "pallet-authorship:4.0.0-dev" "-p" "frame-support:4.0.0-dev" "-p" "frame-support-procedural-tools-derive:3.0.0" "-p" "sc-service:0.10.0-dev" "-p" "sp-debug-derive:4.0.0-dev" "-p" "pallet-tips:4.0.0-dev" "-p" "sc-consensus-uncles:0.10.0-dev" "-p" "sp-inherents:4.0.0-dev" "-p" "sp-panic-handler:4.0.0-dev" "-p" "beefy-gadget-rpc:4.0.0-dev" "-p" "sp-tasks:4.0.0-dev" "-p" "sp-storage:4.0.0-dev" "-p" "pallet-society:4.0.0-dev" "-p" "pallet-mmr-rpc:3.0.0" "-p" "sc-executor-wasmtime:0.10.0-dev" "-p" "pallet-gilt:4.0.0-dev" "-p" "sc-state-db:0.10.0-dev" "-p" "sc-basic-authorship:0.10.0-dev" "-p" "pallet-proxy:4.0.0-dev" "-p" "sc-allocator:4.1.0-dev" "-p" "sc-client-db:0.10.0-dev" "-p" "pallet-authority-discovery:4.0.0-dev" "-p" "pallet-beefy-mmr:4.0.0-dev" "-p" "sp-consensus-slots:0.10.0-dev" "-p" "sp-std:4.0.0-dev" "-p" "pallet-transaction-payment-rpc:4.0.0-dev" "-p" "frame-election-provider-support:4.0.0-dev" "-p" "sc-chain-spec-derive:4.0.0-dev" "-p" "sc-consensus:0.10.0-dev" "-p" "sc-executor-common:0.10.0-dev" "-p" "sc-rpc:4.0.0-dev" "-p" "sp-api-proc-macro:4.0.0-dev" "-p" "pallet-scheduler:4.0.0-dev" "-p" "sc-proposer-metrics:0.10.0-dev" "-p" "fork-tree:3.0.0" "-p" "pallet-offences-benchmarking:4.0.0-dev" "-p" "sc-consensus-babe-rpc:0.10.0-dev" "-p" "sp-npos-elections-solution-type:4.0.0-dev" "-p" "frame-support-test:3.0.0" "-p" "pallet-indices:4.0.0-dev" "-p" "pallet-session:4.0.0-dev" "-p" "beefy-gadget:4.0.0-dev" "-p" "sc-client-api:4.0.0-dev" "-p" "sc-finality-grandpa-rpc:0.10.0-dev" "-p" "sp-transaction-storage-proof:4.0.0-dev", kill_on_drop: false }", status_code: Some(101), err: " Updating git repository https://github.com/paritytech/substrate\nerror: Unable to update https://github.com/paritytech/substrate?branch=master\n\nCaused by:\n failed to parse manifest at /usr/local/cargo/git/checkouts/substrate-7e08433d4c370a21/c9cad66/test-utils/test-crate/Cargo.toml\n\nCaused by:\n feature edition2021 is required\n\n The package requires the Cargo feature called edition2021, but that feature is not stabilized in this version of Cargo (1.55.0 (32da73ab1 2021-08-23)).\n Consider trying a newer version of Cargo (this may require the nightly release).\n See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2021 for more information about the status of this feature.\n" }

shawntabrizi · 2021-12-08T04:38:10Z

/benchmark runtime kusama pallet-bags-list

parity-benchapp · 2021-12-08T04:38:12Z

Benchmark Runtime Kusama Pallet for branch "zeke-put-in-front-of-companion" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet-bags-list --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/

Results

Pallet: "pallet_bags_list", Extrinsic: "rebag_non_terminal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Staking Bonded (r:1 w:0)
Storage: Staking Ledger (r:1 w:0)
Storage: BagsList ListNodes (r:4 w:4)
Storage: BagsList ListBags (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    64.14
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    64.14
              µs

Reads = 7
Writes = 5

Pallet: "pallet_bags_list", Extrinsic: "rebag_terminal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Staking Bonded (r:1 w:0)
Storage: Staking Ledger (r:1 w:0)
Storage: BagsList ListNodes (r:3 w:3)
Storage: BagsList ListBags (r:2 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    61.89
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    61.89
              µs

Reads = 7
Writes = 5

Pallet: "pallet_bags_list", Extrinsic: "put_in_front_of", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: BagsList ListNodes (r:4 w:4)
Storage: Staking Bonded (r:2 w:0)
Storage: Staking Ledger (r:2 w:0)
Storage: BagsList CounterForListNodes (r:1 w:1)
Storage: BagsList ListBags (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    73.68
              µs

Reads = 10
Writes = 6

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    73.68
              µs

Reads = 10
Writes = 6

shawntabrizi · 2021-12-08T04:42:10Z

/benchmark runtime polkadot pallet-bags-list

shawntabrizi · 2021-12-08T04:42:24Z

/benchmark runtime westend pallet-bags-list

…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet-bags-list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/

parity-benchapp · 2021-12-08T04:49:19Z

Benchmark Runtime Westend Pallet for branch "zeke-put-in-front-of-companion" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet-bags-list --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/

Results

Pallet: "pallet_bags_list", Extrinsic: "rebag_non_terminal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Staking Bonded (r:1 w:0)
Storage: Staking Ledger (r:1 w:0)
Storage: BagsList ListNodes (r:4 w:4)
Storage: BagsList ListBags (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    64.32
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    64.32
              µs

Reads = 7
Writes = 5

Pallet: "pallet_bags_list", Extrinsic: "rebag_terminal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Staking Bonded (r:1 w:0)
Storage: Staking Ledger (r:1 w:0)
Storage: BagsList ListNodes (r:3 w:3)
Storage: BagsList ListBags (r:2 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=     62.1
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=     62.1
              µs

Reads = 7
Writes = 5

Pallet: "pallet_bags_list", Extrinsic: "put_in_front_of", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: BagsList ListNodes (r:4 w:4)
Storage: Staking Bonded (r:2 w:0)
Storage: Staking Ledger (r:2 w:0)
Storage: BagsList CounterForListNodes (r:1 w:1)
Storage: BagsList ListBags (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.65
              µs

Reads = 10
Writes = 6

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.65
              µs

Reads = 10
Writes = 6

…k --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet-bags-list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/

parity-benchapp · 2021-12-08T04:55:24Z

Benchmark Runtime Polkadot Pallet for branch "zeke-put-in-front-of-companion" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet-bags-list --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

Results

Pallet: "pallet_bags_list", Extrinsic: "rebag_non_terminal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Staking Bonded (r:1 w:0)
Storage: Staking Ledger (r:1 w:0)
Storage: BagsList ListNodes (r:4 w:4)
Storage: BagsList ListBags (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    64.07
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    64.07
              µs

Reads = 7
Writes = 5

Pallet: "pallet_bags_list", Extrinsic: "rebag_terminal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Staking Bonded (r:1 w:0)
Storage: Staking Ledger (r:1 w:0)
Storage: BagsList ListNodes (r:3 w:3)
Storage: BagsList ListBags (r:2 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    62.28
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    62.28
              µs

Reads = 7
Writes = 5

Pallet: "pallet_bags_list", Extrinsic: "put_in_front_of", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: BagsList ListNodes (r:4 w:4)
Storage: Staking Bonded (r:2 w:0)
Storage: Staking Ledger (r:2 w:0)
Storage: BagsList CounterForListNodes (r:1 w:1)
Storage: BagsList ListBags (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    73.85
              µs

Reads = 10
Writes = 6

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    73.85
              µs

Reads = 10
Writes = 6

…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet-bags-list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

shawntabrizi · 2021-12-08T05:04:39Z

bot merge

paritytech-processbot · 2021-12-08T05:04:47Z

Waiting for commit status.

Companion to Substrate #9829 (Add put_in_front_of)

812053e

emostov mentioned this pull request Sep 21, 2021

Add extrinsic to improve position in a bag of bags-list paritytech/substrate#9829

Merged

1 task

Merge remote-tracking branch 'origin' into zeke-put-in-front-of-compa…

00b21c2

…nion

gui1117 approved these changes Dec 3, 2021

View reviewed changes

emostov added 2 commits December 7, 2021 10:15

Merge remote-tracking branch 'origin' into zeke-put-in-front-of-compa…

9b7ee00

…nion

Add back weight impl for polkadot

9486a39

shawntabrizi approved these changes Dec 8, 2021

View reviewed changes

shawntabrizi added 2 commits December 8, 2021 00:37

Merge branch 'master' into zeke-put-in-front-of-companion

30e8d62

cargo update -p sp-io

a5c9c1d

cargo run --quiet --release --features=runtime-benchmarks -- benchmar…

f3cfce5

…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet-bags-list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/

paritytech-processbot bot merged commit df0e945 into master Dec 8, 2021

paritytech-processbot bot deleted the zeke-put-in-front-of-companion branch December 8, 2021 05:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Companion to Substrate #9829 (Add `put_in_front_of` extrinsic to bags-list)#3899

Companion to Substrate #9829 (Add `put_in_front_of` extrinsic to bags-list)#3899
paritytech-processbot[bot] merged 9 commits intomasterfrom
zeke-put-in-front-of-companion

emostov commented Sep 21, 2021

Uh oh!

gui1117 left a comment

Uh oh!

gui1117 Dec 3, 2021

Uh oh!

emostov Dec 6, 2021

Uh oh!

paritytech-processbot bot commented Dec 8, 2021

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

parity-benchapp bot commented Dec 8, 2021 •

edited

Loading

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

parity-benchapp bot commented Dec 8, 2021 •

edited

Loading

Uh oh!

parity-benchapp bot commented Dec 8, 2021 •

edited

Loading

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

paritytech-processbot bot commented Dec 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

emostov commented Sep 21, 2021

Uh oh!

gui1117 left a comment

Choose a reason for hiding this comment

Uh oh!

gui1117 Dec 3, 2021

Choose a reason for hiding this comment

Uh oh!

emostov Dec 6, 2021

Choose a reason for hiding this comment

Uh oh!

paritytech-processbot bot commented Dec 8, 2021

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

parity-benchapp bot commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

parity-benchapp bot commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parity-benchapp bot commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawntabrizi commented Dec 8, 2021

Uh oh!

paritytech-processbot bot commented Dec 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

parity-benchapp bot commented Dec 8, 2021 •

edited

Loading

parity-benchapp bot commented Dec 8, 2021 •

edited

Loading

parity-benchapp bot commented Dec 8, 2021 •

edited

Loading