This repository was archived by the owner on Nov 15, 2023. It is now read-only.
remove AllSubsystems and AllSubsystemsGen types#3874
Merged
38 commits merged intomasterfrom Sep 29, 2021
Merged
Conversation
drahnr
changed the title
AllSubsystems and AllSubsystemsGen types
drahnr
added
A3-in_progress
drahnr
force-pushed
the
bernhard-remove-all-subsystems-ty
branch
2 times, most recently
from
cb119df to
651b385
Compare
drahnr
force-pushed
the
bernhard-remove-all-subsystems-ty
branch
from
651b385 to
5ff12ab
Compare
drahnr
added
A0-please_review
Co-authored-by: Andronik Ordian <write@reusable.software>
Obsoletes `Overseer::new`, `AllSubsystemsGen` derive macro, `AllSubsystems`.
drahnr
force-pushed
the
bernhard-remove-all-subsystems-ty
branch
from
5711fa1 to
170a7e9
Compare
rphmeier
reviewed
Sep 29, 2021
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
rphmeier
reviewed
Sep 29, 2021
ordian
approved these changes
Sep 29, 2021
rphmeier
reviewed
Sep 29, 2021
| /// | ||
| /// A convenience for usage with malus, to avoid | ||
| /// repetitive code across multiple behavior strain implementations. | ||
| pub fn create_default_subsystems<'a, Spawner, RuntimeClient>( |
Contributor
There was a problem hiding this comment.
Was this moved into malus?
Contributor
Author
There was a problem hiding this comment.
There are no more AllSubsystems instances, so fn prepared_overseer_builder takes its place instead.
Contributor
There was a problem hiding this comment.
I see, malus is now using prepared_overseer_builder.
Contributor
Author
There was a problem hiding this comment.
And fn dummy_overseer_builder respectively.
rphmeier
approved these changes
Sep 29, 2021
Contributor
rphmeier
left a comment
rphmeier
left a comment
There was a problem hiding this comment.
Looks good, although I didn't review the macro code closely.
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Sep 29, 2021
* master: feat: measured oneshots (#3902) remove `AllSubsystems` and `AllSubsystemsGen` types (#3874) Companion for Substrate#9867 (#3938) Substrate Companion for #9552 (#3834) CI: run disputes tests (#3962) Bump parity-scale-codec from 2.3.0 to 2.3.1 (#3959) approval-voting: populate session cache in advance (#3954) Bump libc from 0.2.102 to 0.2.103 (#3950) fix master (#3955) Docker files chore (#3880) Bump nix from 0.19.1 to 0.20.0 (#3587) remove connected disconnected state, 3rd attempt (#3898) fix flaky chain-selection tests (#3948) Add benchmarking for parachain runtime initializer pallet (#3913) minor chore changes (#3944) disputes: reject single-sided disputes (#3903)
ordian
added a commit
that referenced
this pull request
Sep 30, 2021
* master: (52 commits) Companion for substrate PR#9890 (#3961) Bump version, tx_version and spec_version in prep for v0.9.11 (#3970) Fix master compilation (#3977) Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627) fix disputes tests (#3974) Drop availability only for candidates that lose disputes (#3973) revert +1 change to be on the safer side (#3972) paras_inherent: reject only candidates with concluded disputes (#3969) feat: measured oneshots (#3902) remove `AllSubsystems` and `AllSubsystemsGen` types (#3874) Companion for Substrate#9867 (#3938) Substrate Companion for #9552 (#3834) CI: run disputes tests (#3962) Bump parity-scale-codec from 2.3.0 to 2.3.1 (#3959) approval-voting: populate session cache in advance (#3954) Bump libc from 0.2.102 to 0.2.103 (#3950) fix master (#3955) Docker files chore (#3880) Bump nix from 0.19.1 to 0.20.0 (#3587) remove connected disconnected state, 3rd attempt (#3898) ...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of #3803 - will be rebased on-top of #3868 to end up at the same changeset as #3803
Closes #3773