Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

cargo +nightly fmt#3540

Merged
9 commits merged intomasterfrom
shawntabrizi-rustfmt
Aug 2, 2021
Merged

cargo +nightly fmt#3540
9 commits merged intomasterfrom
shawntabrizi-rustfmt

Conversation

@shawntabrizi
Copy link
Copy Markdown
Member

@shawntabrizi shawntabrizi commented Aug 1, 2021 •
edited
Loading

follow up to #3491

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 1, 2021
@ordian
Copy link
Copy Markdown

ordian commented Aug 1, 2021

I think we should add a CI check here as well as was done in paritytech/substrate#9394.

@ordian
Copy link
Copy Markdown

ordian commented Aug 1, 2021

Also the weights autogeneration needs to account for that as well as #3421 (comment).

@shawntabrizi
Copy link
Copy Markdown
Member Author

shawntabrizi commented Aug 1, 2021 •
edited
Loading

Also the weights autogeneration needs to account for that as well as #3421 (comment).

Something for the backlog. Or we just add skip to the generated files.

@shawntabrizi
Copy link
Copy Markdown
Member Author

shawntabrizi commented Aug 1, 2021

bot merge

@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2021

Waiting for commit status.

@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2021

Merge failed: "Waiting on code owner review from HCastano, svyatonik, and/or tomusdrw."

@shawntabrizi
Copy link
Copy Markdown
Member Author

shawntabrizi commented Aug 1, 2021

bot merge

@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2021

Trying merge.

@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2021

Merge failed: "Waiting on code owner review from HCastano, svyatonik, and/or tomusdrw."

HCastano
HCastano approved these changes Aug 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

@HCastano
Copy link
Copy Markdown
Contributor

HCastano commented Aug 2, 2021

On second though, before you merge this can you add this config option:

ignore = [
    "bridges",
]

The bridges repo doesn't use the same rustfmt options and it'll create some unnecessary noise when updating.

@shawntabrizi
Copy link
Copy Markdown
Member Author

shawntabrizi commented Aug 2, 2021

bot merge

@ghost
Copy link
Copy Markdown

ghost commented Aug 2, 2021

Waiting for commit status.

@ghost ghost merged commit c4ee9d4 into master Aug 2, 2021
@ghost ghost deleted the shawntabrizi-rustfmt branch August 2, 2021 10:47
ordian added a commit that referenced this pull request Aug 2, 2021
@ordian
Merge branch 'master' into ao-subsystem-do-not-use-ourviewchange
c59f302 
* master:
  cargo +nightly fmt (#3540)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@svyatonik svyatonik Awaiting requested review from svyatonik

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

4 more reviewers

@pepyakin pepyakin pepyakin approved these changes

@ordian ordian ordian approved these changes

@kianenigma kianenigma kianenigma approved these changes

@HCastano HCastano HCastano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shawntabrizi @ordian @HCastano @pepyakin @kianenigma @bkchr