Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion for substrate#9080#3263

Merged
15 commits merged intoparitytech:masterfrom
koushiro:migrate-pallet-membership
Sep 7, 2021
Merged

Companion for substrate#9080#3263
15 commits merged intoparitytech:masterfrom
koushiro:migrate-pallet-membership

Conversation

@koushiro
Copy link
Copy Markdown
Contributor

@koushiro koushiro commented Jun 16, 2021 •
edited
Loading

Companion for paritytech/substrate#9080

migrate the TechnicalMembership storage prefix (Instance1Membership ==> TechnicalMembership).

@koushiro
runtime(kusama/polkadot): migrations for membership storage prefix
56082ec 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro mentioned this pull request Jun 16, 2021
Merged
@koushiro koushiro marked this pull request as ready for review June 16, 2021 07:44
gui1117
gui1117 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@gui1117 gui1117 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,

Also on rococo the name is not breaking.

@gui1117
Copy link
Copy Markdown
Contributor

gui1117 commented Jun 23, 2021 •
edited
Loading

it would be great to test it once on kusama and polkadot IMHO using try-runtime, or maybe it is simple enough.

@gui1117 gui1117 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 27, 2021
@gui1117
Copy link
Copy Markdown
Contributor

gui1117 commented Aug 27, 2021

I removed the old migration in order to test with try-runtime, so this PR is built on top of #3731

@ghost
Copy link
Copy Markdown

ghost commented Sep 7, 2021

Waiting for commit status.

@ghost ghost merged commit be11414 into paritytech:master Sep 7, 2021
@gui1117
Copy link
Copy Markdown
Contributor

gui1117 commented Sep 7, 2021

thank you Koushiro

@koushiro koushiro deleted the migrate-pallet-membership branch September 7, 2021 14:03
@xlc xlc mentioned this pull request Sep 7, 2021
Closed
5 tasks
@gui1117 gui1117 added the E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. label Sep 9, 2021
@github-actions github-actions bot mentioned this pull request Oct 11, 2021
Closed
@mclyk mclyk mentioned this pull request Oct 25, 2021
Closed
@aurexav aurexav mentioned this pull request Mar 22, 2022
Closed
17 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@KiChjang KiChjang KiChjang approved these changes

@gui1117 gui1117 gui1117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koushiro @gui1117 @KiChjang