Conversation
pepoviola
reviewed
Jun 20, 2023
pepoviola
reviewed
Jun 20, 2023
Contributor
Author
|
Thanks for the comments @pepoviola ! All of them should be addressed by now. |
pepoviola
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
This PR makes the
sendersupport parallel execution. Normal usage is still supported, however.Parallelism is supported by leveraging the same logic, but by replacing the
sender_indexwith a thread index, given that the number of threads passed as an argument to the sender is > 1.Because there was a mix of I/O bound and CPU bound tasks related to sending transactions using
subxt, I split the CPU bound task into aspawn_blockingsection, and used aJoinSetfor the pre-checks which are I/O bound.All the transactions are submitted after all them are signed.
There also had to be changes made to the subxt client (
Apitype here), which was done using theOnlineClient<PolkadotConfig>::from_rpc()method, taking anArc<RpcClient>as an argument. This is because the defaultOnlineClientdoes not support the number of concurrent requests required when thesenderin parallel submits all the transactions. Therefore, the client has to be built with theWsClientBuilderfrom jsonrpsee to set themax_concurrent_requestsparameter in stead. Currently, themax_concurrent_requestsis set tou32::MAX.