Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
added
the
T17-primitives
bkchr
approved these changes
Sep 30, 2025
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Decompression speed should not be impacted by the level or only a little bit. So, this should be good. However, it would be nice to have some rough timings on how much the compilation time of AHM increases because of this extra compression.
acatangiu
approved these changes
Sep 30, 2025
sigurpol
approved these changes
Sep 30, 2025
pepoviola
approved these changes
Sep 30, 2025
Member
Author
|
I checked the build time now after only changing the level and it does not seem to affect it much. 12 sec at most on a not-so-fast single threaded CPU. In the future we can also update the zstd create and enable multi threading for the compression. |
ggwpez
added
the
A4-backport-unstable2507
seadanda
approved these changes
Sep 30, 2025
auto-merge was automatically disabled
September 30, 2025 11:14
Pull Request is not mergeable
ggwpez
removed
the
A4-backport-unstable2507
ggwpez
added a commit
that referenced
this pull request
Sep 30, 2025
bee344
pushed a commit
that referenced
this pull request
Oct 7, 2025
Use strongest compression 22 instead of just 3. See [docs](https://docs.rs/zstd/0.13.3/zstd/stream/write/struct.Encoder.html#method.new). Reduces our KAH compressed size by 25%. Build time by compression level: | Compression | Build Time | Size | Decomp Time | |-------------|-----------|---------|-------------| | 3 | 5:54 | 3192172 | 0.013039s | | 10 | 5:58 | 2716940 | 0.011962s | | 22 | 6:06 | 2387562 | 0.013745s | --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
RomarQ
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Oct 8, 2025
Use strongest compression 22 instead of just 3. See [docs](https://docs.rs/zstd/0.13.3/zstd/stream/write/struct.Encoder.html#method.new). Reduces our KAH compressed size by 25%. Build time by compression level: | Compression | Build Time | Size | Decomp Time | |-------------|-----------|---------|-------------| | 3 | 5:54 | 3192172 | 0.013039s | | 10 | 5:58 | 2716940 | 0.011962s | | 22 | 6:06 | 2387562 | 0.013745s | --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Contributor
|
Really nice improvement 🚀 For moonbeam we have seen a nice difference: |
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Use strongest compression 22 instead of just 3. See [docs](https://docs.rs/zstd/0.13.3/zstd/stream/write/struct.Encoder.html#method.new). Reduces our KAH compressed size by 25%. Build time by compression level: | Compression | Build Time | Size | Decomp Time | |-------------|-----------|---------|-------------| | 3 | 5:54 | 3192172 | 0.013039s | | 10 | 5:58 | 2716940 | 0.011962s | | 22 | 6:06 | 2387562 | 0.013745s | --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
manuelmauro
added a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Oct 31, 2025
Use strongest compression 22 instead of just 3. See [docs](https://docs.rs/zstd/0.13.3/zstd/stream/write/struct.Encoder.html#method.new). Reduces our KAH compressed size by 25%. Build time by compression level: | Compression | Build Time | Size | Decomp Time | |-------------|-----------|---------|-------------| | 3 | 5:54 | 3192172 | 0.013039s | | 10 | 5:58 | 2716940 | 0.011962s | | 22 | 6:06 | 2387562 | 0.013745s | --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
RomarQ
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Nov 18, 2025
Use strongest compression 22 instead of just 3. See [docs](https://docs.rs/zstd/0.13.3/zstd/stream/write/struct.Encoder.html#method.new). Reduces our KAH compressed size by 25%. Build time by compression level: | Compression | Build Time | Size | Decomp Time | |-------------|-----------|---------|-------------| | 3 | 5:54 | 3192172 | 0.013039s | | 10 | 5:58 | 2716940 | 0.011962s | | 22 | 6:06 | 2387562 | 0.013745s | --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
RomarQ
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Nov 18, 2025
Use strongest compression 22 instead of just 3. See [docs](https://docs.rs/zstd/0.13.3/zstd/stream/write/struct.Encoder.html#method.new). Reduces our KAH compressed size by 25%. Build time by compression level: | Compression | Build Time | Size | Decomp Time | |-------------|-----------|---------|-------------| | 3 | 5:54 | 3192172 | 0.013039s | | 10 | 5:58 | 2716940 | 0.011962s | | 22 | 6:06 | 2387562 | 0.013745s | --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
RomarQ
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Nov 18, 2025
Use strongest compression 22 instead of just 3. See [docs](https://docs.rs/zstd/0.13.3/zstd/stream/write/struct.Encoder.html#method.new). Reduces our KAH compressed size by 25%. Build time by compression level: | Compression | Build Time | Size | Decomp Time | |-------------|-----------|---------|-------------| | 3 | 5:54 | 3192172 | 0.013039s | | 10 | 5:58 | 2716940 | 0.011962s | | 22 | 6:06 | 2387562 | 0.013745s | --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use strongest compression 22 instead of just 3. See docs.
Reduces our KAH compressed size by 25%.
Build time by compression level: