Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
the
R0-no-crate-publish-required
alvicsam
approved these changes
Sep 24, 2025
bkchr
approved these changes
Sep 24, 2025
skunert
approved these changes
Sep 24, 2025
lrubasze
approved these changes
Sep 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
This PR adds the `--locked` option to the cargo doc tests. Detected by running the CI on PR: https://github.com/paritytech/polkadot-sdk/actions/runs/17972092266/job/51117118432 ```rust error[E0277]: the trait bound `BoundedVec<u8, v3::MaxPalletNameLen>: JsonSchema` is not satisfied --> polkadot/xcm/src/v3/mod.rs:228:12 | 228 | pub name: BoundedVec<u8, MaxPalletNameLen>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `JsonSchema` is not implemented for `BoundedVec<u8, v3::MaxPalletNameLen>` | note: there are multiple different versions of crate `schemars` in the dependency graph --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/schemars-0.8.22/src/lib.rs:133:1 | 133 | pub trait JsonSchema { | ^^^^^^^^^^^^^^^^^^^^ this is the required trait | ::: polkadot/xcm/src/v3/junction.rs:49:44 | 49 | #[cfg_attr(feature = "json-schema", derive(schemars::JsonSchema))] | -------- one version of crate `schemars` used here, as a direct dependency of the current crate | ::: polkadot/xcm/src/lib.rs:31:5 ``` Thanks @bkchr for the suggestion here 🙏 This has been detected while working on: - #9418 Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
--lockedoption to the cargo doc tests.Detected by running the CI on PR: https://github.com/paritytech/polkadot-sdk/actions/runs/17972092266/job/51117118432
Thanks @bkchr for the suggestion here 🙏
This has been detected while working on: