Update elastic scaling documentation#9677
Conversation
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
|
/cmd prdoc generate --bump major |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…/polkadot-sdk into sandreim/elastic_scaling_docs
| //! This commitment is implemented via `UMP` signals, which rely on the upward message passing channel that | ||
| //! is used by parachains to send messages to the relay chain. | ||
| //! | ||
| //! The only required change for the runtime is enabling the `experimental-ump-signals` feature of the `parachain-system` |
There was a problem hiding this comment.
Why is this still experimental? When will we no longer make it experimental?
There was a problem hiding this comment.
Because it is not enabled on Polkadot yet. I plan to remove this feature completely as soon as RFC103 is enabled on Polkadot.
There was a problem hiding this comment.
Nice! I left some suggestions for improvement. There is a minor lack of consistency between 6s and 6 seconds also I think it is good practice to use Three cores instead of 3 cores, I think the "threshold" is numbers less than 10 one typically writes as words?
Good job! :)
Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com>
Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com>
Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com>
Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com>
Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com>
|
We should also add a note about customizing the block authoring duration on the collator |
What is customisable that is requirement ? |
The omni node hardcodes this to 2 seconds. If a parachain wants to have 12 cores with 500ms block times, they need to lower this. We probably need to add this parameter to the omni node CLI. WDYT @skunert ? |
AFAIK this authoring duration gets adjusted based on this, you don't need to change it. LE: However it seems to be used only to compute the block production interval, still 2s getting passed to proposer. |
|
This is a good point, we currently don't have any description of the timings and how they need to be adjusted. I know that @bkchr is working on dynamic timings and weight adjustments in the runtime. Until that is done, we only have shitty solutions. For any number of cores, you would need to adjust the weight in your runtime right? Otherwise, how would we know when to stop authoring. This is the proper way to do it. But at the same time, its a problem if someone wants to have these 12 cores. Do we want people to set their runtime weight to 500ms? Probably not. So we would indeed need to handle everything node-side and adjust this |
They will need to change their weight. This is basically an upper bound on what the node will use. When the block finishes after 500ms, the block production stops before.
Yes this will be fixed by my work. If anyone right now really needs this, they need to go with the |
For elastic scaling, when we have a full core to fill, wouldn't it be better if we don't limit the weight ? Parachains can run faster collators and fill in more than 500ms ref time with 500ms authorship duration. |
|
/cmd fmt |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…/polkadot-sdk into sandreim/elastic_scaling_docs Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
Successfully created backport PR for |
Closes #9677 Add docs and remove MVP. --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com> Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Alin Dima <alin@parity.io> (cherry picked from commit 7af791f)
Backport #9677 into `stable2509` from sandreim. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com> Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Alin Dima <alin@parity.io>
Follow-up to #9677 . I think it would be good to add our view on the slot duration, as it is often confused with the actual block production interval. This short addition should clarify things a bit. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
Follow-up to #9677 . I think it would be good to add our view on the slot duration, as it is often confused with the actual block production interval. This short addition should clarify things a bit. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit fbf98c8)
Follow-up to #9677 . I think it would be good to add our view on the slot duration, as it is often confused with the actual block production interval. This short addition should clarify things a bit. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
Closes #9677 Add docs and remove MVP. --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com> Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Alin Dima <alin@parity.io>
Follow-up to #9677 . I think it would be good to add our view on the slot duration, as it is often confused with the actual block production interval. This short addition should clarify things a bit. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
Closes #9677
Add docs and remove MVP.