[pallet-revive] memory bounds check#9635
Merged
pgherveou merged 12 commits intorve/revm-instructions-bitwisefrom Sep 4, 2025
Merged
[pallet-revive] memory bounds check#9635pgherveou merged 12 commits intorve/revm-instructions-bitwisefrom
pgherveou merged 12 commits intorve/revm-instructions-bitwisefrom
Conversation
xermicus
approved these changes
Sep 4, 2025
| /// Revert if the memory is out of bounds. | ||
| #[macro_export] | ||
| macro_rules! resize_memory { | ||
| macro_rules! check_memory_bounds { |
Contributor
Author
There was a problem hiding this comment.
right now yes, because it returns on Error and all the REVM function do not return Result so you can't use ? to propagate errors
athei
approved these changes
Sep 4, 2025
Co-authored-by: xermicus <[email protected]>
pgherveou
merged commit 5404906
into
rve/revm-instructions-bitwise
42 of 44 checks passed
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit EVM memory to the same amount as PVM memory