revive/types: Implement the ethereum 7702 transaction by lexnv · Pull Request #9538 · paritytech/polkadot-sdk

lexnv · 2025-08-21T17:02:07Z

This PR implements the Ethereum 7702 transaction:

https://eips.ethereum.org/EIPS/eip-7702

While at it, have added a few serialization tests to ensure our block decoding doesn't panic.

Builds opon: #9418

Closes: paritytech/contract-issues#146

Part of: paritytech/contract-issues#139

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

pgherveou · 2025-08-21T20:14:03Z

Ah i think I implemented here as well, both pr should be pretty similar I guess,
Will review and approve tomorrow

If you can pickup any differences with this one let me know

#9177

pgherveou · 2025-08-22T08:16:48Z

will merge the diff in #9177

pgherveou · 2025-08-22T08:41:37Z

@lexnv re-opening here, but I think we should merge master and fix it up once the other PR mentioned above is merged

pgherveou · 2025-08-22T08:35:19Z

substrate/frame/revive/src/evm/api/rlp_codec.rs

+		s.append(&self.r);
+		s.append(&self.s);
+		s.append(&self.y_parity);


I think the order is wrong here

Thanks for the catch! 🙏 Yep it looks to be:

authorization_list = [[chain_id, address, nonce, y_parity, r, s], ...]

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

athei · 2025-08-22T12:04:30Z

Is it a good idea to implement the tx type without the actual functionality? We are just ignoring those new fields?

pgherveou · 2025-08-22T12:13:29Z

Is it a good idea to implement the tx type without the actual functionality? We are just ignoring those new fields?

it's moved to #9177 the tx types are rejected, when we try to convert them to call

… into lexnv/eth-eip7702 Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lrubasze

LGTM

lrubasze · 2025-08-27T06:39:22Z

substrate/frame/revive/src/evm/block_hash.rs

 			extra_data: self.extra_data.clone().0.into(),
 			mix_hash: self.mix_hash.0.into(),
 			nonce: self.nonce.0.into(),
+			// <<<<<<< HEAD


What's the purpose of leaving this commented section?

lrubasze · 2025-08-27T06:46:06Z

substrate/frame/revive/src/evm/block_hash.rs

+			.collect();
+		// Sort by nibble key.
+		// This gives the right lexicographical order to add leaves to the trie.
+		pairs.sort_by(|x, y| x.0.cmp(&y.0));


After investigating the trie root computation we know that pair at index 0 has key 0x80 and should be moved at position 0x80 or last (if number of elements is less than 0x80). No need to sort.

This PR compares the incremental trie builder approach with the in-storage approach. This uses real-life ethereum blocks to determine how many bytes we need to store. ### Storage Usage In the worst-case scenario, the validator needs to store in RAM 8004 bytes vs 80538 bytes. This represents roughly 9.9% of the initial data. At a minimum, best case scenario, the validator needs to sore just 406 bytes. This represents roughly 0.5% of the initial data. ``` For tx=6 using index=7 HB size is: 8004 vs total 80538 For tx=64 using index=65 HB size is: 406 vs total 80538 ``` This approach shows that we can optimize the storage items from (between 90-99%): - #9418 ### Implementation Idea Currently, we hold in the storage of pallet/revive the RLP encoded transaction bytes. This represents a [Vec<Vec<u8>>](https://github.com/paritytech/polkadot-sdk/pull/9418/files#diff-f55a8416f5e8564cb4463b5f11dfd00d7c865aabab747a05887feeedd4e1c81dR570-R571) that is used to build the transaction trie root hash. Instead, we place a newly added low-level structure `IncrementalTrieBuilder` into an `environmental` variable. When we receive a transaction, instead of pushing it to the `Vec<Vec<u8>>`, we add it to the low-level builder. This effectively will use the `8004` bytes plus the RLP encodings of a maximum of 2 transactions. --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com> Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: muharem <ismailov.m.h@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Evgeny Snitko <evgeny@parity.io> Co-authored-by: alvicsam <alvicsam@gmail.com> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: sistemd <enntheprogrammer@gmail.com> Co-authored-by: Veronika Romashkina <vrom911@gmail.com> Co-authored-by: Raymond Cheung <178801527+raymondkfcheung@users.noreply.github.com> Co-authored-by: Andrei Eres <eresav@me.com> Co-authored-by: Haiko Schol <hs+github@haikoschol.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Karol Kokoszka <karol@parity.io> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: xermicus <cyrill@parity.io> Co-authored-by: 0xRVE <robertvaneerdewijk@gmail.com> Co-authored-by: Robert van Eerdewijk <robert@Roberts-MacBook-Pro.local> Co-authored-by: Sebastian Miasojed <s.miasojed@gmail.com> Co-authored-by: Cyrill Leutwiler <bigcyrill@hotmail.com> Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Lukasz Rubaszewski <117115317+lrubasze@users.noreply.github.com> Co-authored-by: Alexander Cyon <Sajjon@users.noreply.github.com> Co-authored-by: Alexander Cyon <alex.cyon@parity.com> Co-authored-by: Dmitry Sinyavin <dmitry.sinyavin@parity.io> Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com> Co-authored-by: Paolo La Camera <paolo@parity.io> Co-authored-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> Co-authored-by: Sebastian Miasojed <sebastian.miasojed@parity.io> Co-authored-by: Egor_P <egor@parity.io> Co-authored-by: Bruno Devic <bruno.devic@parity.io> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Alin Dima <alin@parity.io> Co-authored-by: Klapeyron <11329616+Klapeyron@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: drskalman <35698397+drskalman@users.noreply.github.com> Co-authored-by: Davide Galassi <davxy@datawok.net> Co-authored-by: Michael Müller <mich@elmueller.net> Co-authored-by: Doordashcon <jesse.chejieh@gmail.com> Co-authored-by: Andrii <ndk@parity.io>

paritytech-workflow-stopper · 2025-09-17T12:59:50Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/17798151508
Failed job name: cargo-clippy

paritytech-workflow-stopper · 2025-09-17T12:59:50Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/17798151547
Failed job name: test-linux-stable

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

…ons (#9764) This is a combination of: - #9538 - #9554 - Because I've merged origin/master into the 3 PR in the tree series, which led to reporting all in-between commits as part of the PRs For tracking purposes only. --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Lukasz Rubaszewski <117115317+lrubasze@users.noreply.github.com>

lexnv added 4 commits August 21, 2025 16:08

revive: Implement latest tx type

c59960d

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive: Implement signature type

c23e01f

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive: Implement Encode and Decode

2420206

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive: Fixes and testing cases

efffc74

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv self-assigned this Aug 21, 2025

lexnv added the T0-node This PR/Issue is related to the topic “node”. label Aug 21, 2025

lexnv requested review from athei, lrubasze and pgherveou August 21, 2025 17:03

lexnv added 3 commits August 21, 2025 17:24

revive/block: Ensure ETH block hash is identical

2d02c96

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive/tests: Add tests assets with receipt and blocks

fa02002

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive: Add requests_hash to the ethereum block for decoding

a788255

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

pgherveou closed this Aug 22, 2025

pgherveou reopened this Aug 22, 2025

pgherveou reviewed Aug 22, 2025

View reviewed changes

lexnv mentioned this pull request Aug 22, 2025

align eth-rpc response with geth #9177

Merged

lexnv added 4 commits August 22, 2025 11:40

revive: Fetch the type of the transaction

b7d3de5

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive/exec: Fall back to system block hashes

20d8b0b

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive/tests: Add tests with real block hashes

aab1cd9

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive/tests: Remove commented code

e54b3ea

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv added 3 commits August 26, 2025 11:54

Merge remote-tracking branch 'origin/lexnv/minimal-poc-block-storage'…

e0fa53a

… into lexnv/eth-eip7702 Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive/fix: Fix 7702 encoding to valid addresses

f58a71b

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

revive/tests: Remove debug code

a8fe6b2

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lrubasze approved these changes Aug 27, 2025

View reviewed changes

lexnv mentioned this pull request Sep 2, 2025

Ethereum Block Storage paritytech/contract-issues#139

Closed

8 tasks

lexnv requested review from a team as code owners September 17, 2025 12:49

lexnv merged commit 4009539 into lexnv/minimal-poc-block-storage Sep 17, 2025
69 of 70 checks passed

lexnv deleted the lexnv/eth-eip7702 branch September 17, 2025 12:50

lexnv added a commit that referenced this pull request Sep 17, 2025

Manually merge #9554 and github.com//pull/9538

5b4ea11

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv mentioned this pull request Sep 17, 2025

changes: Compare incremental Trie Builder for space saveup optimizations #9764

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

revive/types: Implement the ethereum 7702 transaction#9538

revive/types: Implement the ethereum 7702 transaction#9538
lexnv merged 15 commits intolexnv/minimal-poc-block-storagefrom
lexnv/eth-eip7702

lexnv commented Aug 21, 2025 •

edited

Loading

Uh oh!

pgherveou commented Aug 21, 2025

Uh oh!

pgherveou commented Aug 22, 2025

Uh oh!

pgherveou commented Aug 22, 2025

Uh oh!

pgherveou Aug 22, 2025

Uh oh!

lexnv Aug 22, 2025

Uh oh!

athei commented Aug 22, 2025

Uh oh!

pgherveou commented Aug 22, 2025

Uh oh!

lrubasze left a comment

Uh oh!

lrubasze Aug 27, 2025

Uh oh!

lrubasze Aug 27, 2025

Uh oh!

Uh oh!

paritytech-workflow-stopper bot commented Sep 17, 2025

Uh oh!

paritytech-workflow-stopper bot commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lexnv commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgherveou commented Aug 21, 2025

Uh oh!

pgherveou commented Aug 22, 2025

Uh oh!

pgherveou commented Aug 22, 2025

Uh oh!

pgherveou Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

lexnv Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

athei commented Aug 22, 2025

Uh oh!

pgherveou commented Aug 22, 2025

Uh oh!

lrubasze left a comment

Choose a reason for hiding this comment

Uh oh!

lrubasze Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

lrubasze Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paritytech-workflow-stopper bot commented Sep 17, 2025

Uh oh!

paritytech-workflow-stopper bot commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lexnv commented Aug 21, 2025 •

edited

Loading