Replace `log` with `tracing` on `xcm-emulator` by raymondkfcheung · Pull Request #9409 · paritytech/polkadot-sdk

raymondkfcheung · 2025-07-31T15:22:43Z

This PR replaces log with tracing instrumentation on xcm-emulator by providing structured logging.

Continues #8732

bkchr · 2025-07-31T21:33:42Z

cumulus/xcm/xcm-emulator/src/lib.rs

 						// log events
 						<Self as $crate::Chain>::events().iter().for_each(|event| {
-							$crate::log::info!(target: concat!("events::", stringify!($name)), "{:?}", event);
+							$crate::tracing::info!(target: concat!("events::", stringify!($name)), "{:?}", event);


Suggested change

$crate::tracing::info!(target: concat!("events::", stringify!($name)), "{:?}", event);

$crate::tracing::info!(target: concat!("events::", stringify!($name)), ?event, "Event processed");

bkchr · 2025-07-31T21:34:12Z

cumulus/xcm/xcm-emulator/src/lib.rs

 										(*block, $crate::array_bytes::bytes2hex("0x", message))
 									}).collect::<Vec<_>>();
-									$crate::log::info!(target: concat!("xcm::dmp::", stringify!($name)) , "Downward messages processed by para_id {:?}: {:?}", &to_para_id, messages);
+									$crate::tracing::info!(target: concat!("xcm::dmp::", stringify!($name)) , "Downward messages processed by para_id {:?}: {:?}", &to_para_id, messages);


Suggested change

$crate::tracing::info!(target: concat!("xcm::dmp::", stringify!($name)) , "Downward messages processed by para_id {:?}: {:?}", &to_para_id, messages);

$crate::tracing::info!(target: concat!("xcm::dmp::", stringify!($name)) , ?to_para_id, ?messages, "Downward messages processed");

bkchr · 2025-07-31T21:34:39Z

cumulus/xcm/xcm-emulator/src/lib.rs

 									(*para_id, *relay_block_number, $crate::array_bytes::bytes2hex("0x", message))
 								}).collect::<Vec<_>>();
-								$crate::log::info!(target: concat!("xcm::hrmp::", stringify!($name)), "Horizontal messages processed by para_id {:?}: {:?}", &to_para_id, &messages);
+								$crate::tracing::info!(target: concat!("xcm::hrmp::", stringify!($name)), "Horizontal messages processed by para_id {:?}: {:?}", &to_para_id, &messages);


Suggested change

$crate::tracing::info!(target: concat!("xcm::hrmp::", stringify!($name)), "Horizontal messages processed by para_id {:?}: {:?}", &to_para_id, &messages);

$crate::tracing::info!(target: concat!("xcm::hrmp::", stringify!($name)), ?to_para_id, ?messages, "Horizontal messages processed");

bkchr · 2025-07-31T21:35:09Z

cumulus/xcm/xcm-emulator/src/lib.rs

 						});
 						let message = $crate::array_bytes::bytes2hex("0x", msg.clone());
-						$crate::log::info!(target: concat!("xcm::ump::", stringify!($name)) , "Upward message processed from para_id {:?}: {:?}", &from_para_id, &message);
+						$crate::tracing::info!(target: concat!("xcm::ump::", stringify!($name)) , "Upward message processed from para_id {:?}: {:?}", &from_para_id, &message);


Suggested change

$crate::tracing::info!(target: concat!("xcm::ump::", stringify!($name)) , "Upward message processed from para_id {:?}: {:?}", &from_para_id, &message);

$crate::tracing::info!(target: concat!("xcm::ump::", stringify!($name)) , ?from_para_id, ?message, "Upward message processed");

bkchr · 2025-07-31T21:35:27Z

cumulus/xcm/xcm-emulator/src/lib.rs

 									<<Self::Bridge as Bridge>::Handler as BridgeMessageHandler>::notify_source_message_delivery(msg.lane_id.clone());
 								});
-								$crate::log::info!(target: concat!("bridge::", stringify!($name)) , "Bridged message processed {:?}", msg);
+								$crate::tracing::info!(target: concat!("bridge::", stringify!($name)) , "Bridged message processed {:?}", msg);


Suggested change

$crate::tracing::info!(target: concat!("bridge::", stringify!($name)) , "Bridged message processed {:?}", msg);

$crate::tracing::info!(target: concat!("bridge::", stringify!($name)) , ?msg, "Bridged message processed");

bkchr · 2025-07-31T21:35:42Z

cumulus/xcm/xcm-emulator/src/lib.rs

 			// Log all events (since they won't be logged after the panic).
 			<$chain as $crate::Chain>::events().iter().for_each(|event| {
-				$crate::log::info!(target: concat!("events::", stringify!($chain)), "{:?}", event);
+				$crate::tracing::info!(target: concat!("events::", stringify!($chain)), "{:?}", event);


Suggested change

$crate::tracing::info!(target: concat!("events::", stringify!($chain)), "{:?}", event);

$crate::tracing::info!(target: concat!("events::", stringify!($chain)), event, "Event processed");

bkchr · 2025-07-31T21:36:19Z

cumulus/xcm/xcm-emulator/src/lib.rs

 						// log events
 						Self::events().iter().for_each(|event| {
-							$crate::log::info!(target: concat!("events::", stringify!($name)), "{:?}", event);
+							$crate::tracing::info!(target: concat!("events::", stringify!($name)), "{:?}", event);


Suggested change

$crate::tracing::info!(target: concat!("events::", stringify!($name)), "{:?}", event);

$crate::tracing::info!(target: concat!("events::", stringify!($name)), ?event, "Event processed");

This PR replaces `log` with `tracing` instrumentation on `xcm-emulator` by providing structured logging. Continues #8732

Replace log with tracing on xcm-emulator

e7718ba

raymondkfcheung self-assigned this Jul 31, 2025

raymondkfcheung added the T6-XCM This PR/Issue is related to XCM. label Jul 31, 2025

raymondkfcheung requested a review from a team July 31, 2025 15:24

raymondkfcheung enabled auto-merge July 31, 2025 15:52

bkchr approved these changes Jul 31, 2025

View reviewed changes

raymondkfcheung added 2 commits August 1, 2025 09:44

Update tracing

4060d0d

Merge branch 'master' into ray-xcm-tracing

e3ae198

raymondkfcheung added the C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. label Aug 1, 2025

x3c41a approved these changes Aug 4, 2025

View reviewed changes

raymondkfcheung added this pull request to the merge queue Aug 4, 2025

Merged via the queue into master with commit c16e9e2 Aug 4, 2025
319 of 324 checks passed

raymondkfcheung deleted the ray-xcm-tracing branch August 4, 2025 13:41

alvicsam pushed a commit that referenced this pull request Oct 17, 2025

Replace log with tracing on xcm-emulator (#9409)

5bf47e7

This PR replaces `log` with `tracing` instrumentation on `xcm-emulator` by providing structured logging. Continues #8732

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

	$crate::tracing::info!(target: concat!("events::", stringify!($name)), "{:?}", event);
	$crate::tracing::info!(target: concat!("events::", stringify!($name)), ?event, "Event processed");

Conversation

raymondkfcheung commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

raymondkfcheung commented Jul 31, 2025 •

edited

Loading